Hi, there's potential seeking related data corruption in WebKitWebSrc, see this gst-plugins-good commit for an explanation: http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/ext/soup/gstsouphttpsrc.c?id=95f6e0dbe440cc0399a54221d672f11e4e1d6ee8 The code in WebKitWebSrc is doing basically the same and attached patch fixes it in the same way
Created attachment 192298 [details] Fix offset handling in GStreamer WebKitWebSource Also the offset handling was completely broken after a seek (offsets were starting at 0 again instead of the seek position), this patch fixes it now.
Created attachment 192301 [details] Fix offset handling in GStreamer WebKitWebSource
I should mention that this also causes these warnings in the GStreamer debug logs: 0:00:00.799966750 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 0 != 99761158 0:00:00.814100750 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 11154 != 99772312 0:00:00.818346833 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 14050 != 99775208 0:00:00.827516708 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 32874 != 99794032 0:00:00.835650083 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 35770 != 99796928 0:00:00.851485041 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 40114 != 99801272 0:00:00.856966208 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 48802 != 99809960 0:00:00.867456083 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 51698 != 99812856 0:00:00.871585125 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 57490 != 99818648 0:00:00.874578917 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 76314 != 99837472 0:00:00.877421333 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 77762 != 99838920 0:00:00.882384875 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 82106 != 99843264 0:00:00.885572791 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 86450 != 99847608 0:00:00.886786250 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 89346 != 99850504 0:00:00.888003333 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 92242 != 99853400 0:00:00.890657875 32616 0x1d4600 WARN queue2 gstqueue2.c:1610:gst_queue2_create_write:<queue2-0> buffer offset does not match current writing position! 95138 != 99856296
Comment on attachment 192301 [details] Fix offset handling in GStreamer WebKitWebSource Thanks!
Comment on attachment 192301 [details] Fix offset handling in GStreamer WebKitWebSource Clearing flags on attachment: 192301 Committed r145318: <http://trac.webkit.org/changeset/145318>
All reviewed patches have been landed. Closing bug.
This should probably be merged into the WebKitGTK 2.x branch. Do you mind adding it to the merge tracker?
How?
Sorry. You should just add a link to the trac commit page to http://trac.webkit.org/wiki/WebKitGTK/2.0.x .