Bug 111879 - Don't use bash constructs in Source/autotools/FindDependencies.m4
Summary: Don't use bash constructs in Source/autotools/FindDependencies.m4
Status: RESOLVED DUPLICATE of bug 117796
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-08 11:28 PST by Landry Breuil
Modified: 2013-10-09 23:02 PDT (History)
4 users (show)

See Also:

Attachments
Use a="$a foo" to append instead of using a+=" foo" (1.46 KB, patch)
2013-03-08 11:28 PST, Landry Breuil 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Landry Breuil 2013-03-08 11:28:21 PST 
Created attachment 192255 [details]
Use a="$a foo" to append instead of using a+=" foo"

https://bugs.webkit.org/show_bug.cgi?id=109246 splitted stuff from configure.ac to Source/autotools.

As it is now, it doesnt build on hosts where sh is not bash, because it uses a+="foo" constructs which are not valid in posix shells.

$a+="bar"
ksh: a+=bar: not found
Comment 1 WebKit Review Bot 2013-03-08 11:32:27 PST 
Attachment 192255 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Alberto Garcia 2013-10-09 14:59:40 PDT 
lgtm
Comment 3 Zan Dobersek 2013-10-09 23:01:50 PDT 
This was fixed under bug #117796.

*** This bug has been marked as a duplicate of bug 117796 ***
Comment 4 Zan Dobersek 2013-10-09 23:02:59 PDT 
Comment on attachment 192255 [details]
Use a="$a foo" to append instead of using a+=" foo"

Still, thanks for reporting.