The warning is: ../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::unavailablePluginButtonClicked' [-Wmissing-field-initializers]
(In reply to comment #0) > The warning is: > ../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::unavailablePluginButtonClicked' [-Wmissing-field-initializers] Sorry this one is in master not in the stable branch, the one in the stable branch is: ../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::pluginLoadPolicy' [-Wmissing-field-initializers]
Created attachment 192233 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 192233 [details] Patch Looks good to me.
Committed in the stable branch http://trac.webkit.org/changeset/145234
Adding WK2 owners to CC.
Comment on attachment 192233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192233&action=review Please fix the name before landing. > Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211 > + 0, // pluginLoadPolicy In my repository, this callback is named "unavailablePluginButtonClicked"
Comment on attachment 192233 [details] Patch Attachment 192233 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17060461 New failing tests: fast/css/sticky/inline-sticky.html
Comment on attachment 192233 [details] Patch Clearing flags on attachment: 192233 Committed r145308: <http://trac.webkit.org/changeset/145308>
All reviewed patches have been landed. Closing bug.