Bug 111863 – [Stable][GTK][WK2] Fix compilation warning missing-field-initializers in webkit-2.0 stable branch

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Manuel Rego Casasnovas]

The warning is:
../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::unavailablePluginButtonClicked' [-Wmissing-field-initializers]

[Manuel Rego Casasnovas]

(In reply to comment #0)
> The warning is:
> ../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::unavailablePluginButtonClicked' [-Wmissing-field-initializers]

Sorry this one is in master not in the stable branch, the one in the stable branch is:

../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::pluginLoadPolicy' [-Wmissing-field-initializers]

[Manuel Rego Casasnovas]

Created attachment 192233 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 192233 [details]
Patch

Looks good to me.

[Carlos Garcia Campos]

Committed in the stable branch http://trac.webkit.org/changeset/145234

[Manuel Rego Casasnovas]

Adding WK2 owners to CC.

[Benjamin Poulain]

Comment on attachment 192233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192233&action=review

Please fix the name before landing.

> Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211
> +        0, // pluginLoadPolicy

In my repository, this callback is named "unavailablePluginButtonClicked"

[Build Bot]

Comment on attachment 192233 [details]
Patch

Attachment 192233 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17060461

New failing tests:
fast/css/sticky/inline-sticky.html

[WebKit Review Bot]

Comment on attachment 192233 [details]
Patch

Clearing flags on attachment: 192233

Committed r145308: <http://trac.webkit.org/changeset/145308>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.