111854 – Making more sophisticated cache flush on ARM Linux platform

Bug 111854 - Making more sophisticated cache flush on ARM Linux platform

Summary: Making more sophisticated cache flush on ARM Linux platform

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Linux

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-03-08 07:04 PST by Gabor Rapcsanyi
Modified:	2013-03-12 02:47 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
proposed patch (5.78 KB, patch) 2013-03-08 08:08 PST, Gabor Rapcsanyi	zherczeg: review- zherczeg: commit-queue-	Details \| Formatted Diff \| Diff
proposed patch 2 (5.78 KB, patch) 2013-03-11 05:51 PDT, Gabor Rapcsanyi	zherczeg: review+ zherczeg: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gabor Rapcsanyi 2013-03-08 07:04:58 PST

Now the cache flush on ARM Linux is invalidate whole pages instead of just the required areas.

Comment 1 Gabor Rapcsanyi 2013-03-08 08:08:19 PST

Created attachment 192231 [details]
proposed patch

With this solution we go through all the affected pages and invalidate just the required areas.

Comment 2 Zoltan Herczeg 2013-03-11 05:08:05 PDT

Comment on attachment 192231 [details]
proposed patch

Nice patch, but:

View in context: https://bugs.webkit.org/attachment.cgi?id=192231&action=review

> Source/JavaScriptCore/assembler/ARMAssembler.h:1060
> +            for (current = firstPageEnd; current < end; current += pageSize())

I think this is incorrect. Are you sure it is not "current + pageSize() < end"?

Comment 3 Gabor Rapcsanyi 2013-03-11 05:51:18 PDT

Created attachment 192451 [details]
proposed patch 2

I've fixed that condition in the for cycle.

Comment 4 Zoltan Herczeg 2013-03-12 02:21:30 PDT

Comment on attachment 192451 [details]
proposed patch 2

r=me.

View in context: https://bugs.webkit.org/attachment.cgi?id=192451&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        The cache flush on ARM Linux is invalidate whole pages
> +        instead of just the required areas.

Fix grammar please.

Comment 5 Gabor Rapcsanyi 2013-03-12 02:47:08 PDT

Thanks!
Patch landed: http://trac.webkit.org/changeset/145505