Bug 111822 - Infinite loop due to bad use tree cycle detection
Summary: Infinite loop due to bad use tree cycle detection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philip Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 22:49 PST by Philip Rogers
Modified: 2013-03-08 06:40 PST (History)
5 users (show)

See Also:

Attachments
Prevent infinite loop (3.44 KB, patch)
2013-03-07 23:22 PST, Philip Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rogers 2013-03-07 22:49:07 PST 
We can infinite loop during use tree cycle detection with ids containing capital letters.

The bug is conveniently labeled with a fixme!
http://trac.webkit.org/browser/trunk/Source/WebCore/svg/SVGUseElement.cpp?annotate=blame#L672

Testcase:
<svg>
<g id="R">
<use id="test" xlink:href="#R">
</svg>

Original bug: crbug.com/181016
Comment 1 Philip Rogers 2013-03-07 23:22:16 PST 
Created attachment 192158 [details]
Prevent infinite loop
Comment 2 Stephen Chenney 2013-03-08 06:34:25 PST 
Comment on attachment 192158 [details]
Prevent infinite loop

Look good to me. R=me.
Comment 3 WebKit Review Bot 2013-03-08 06:40:07 PST 
Comment on attachment 192158 [details]
Prevent infinite loop

Clearing flags on attachment: 192158

Committed r145216: <http://trac.webkit.org/changeset/145216>
Comment 4 WebKit Review Bot 2013-03-08 06:40:10 PST 
All reviewed patches have been landed.  Closing bug.