Bug 111820 - WebPage::scaledSnapshotWithOptions returns a corrupt snapshot if you request a rect larger than the FrameView’s size
Summary: WebPage::scaledSnapshotWithOptions returns a corrupt snapshot if you request ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-07 21:46 PST by Tim Horton
Modified: 2013-03-10 23:32 PDT (History)
2 users (show)

See Also:

Attachments
patch (1.54 KB, patch)
2013-03-07 21:49 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (1.51 KB, patch)
2013-03-07 22:00 PST, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-03-07 21:46:14 PST 
We have to clear the image if there’s area that won’t be painted by the FrameView.

<rdar://problem/13375785>
Comment 1 Tim Horton 2013-03-07 21:49:46 PST 
Created attachment 192143 [details]
patch
Comment 2 Tim Horton 2013-03-07 21:51:38 PST 
Wait, the coordinates are mixed up.
Comment 3 Tim Horton 2013-03-07 21:56:00 PST 
Maybe we should just unconditionally clear the image — FrameView has the ability to have a non-opaque background, which would still be broken with the “if there’s area that won’t be painted by the FrameView” approach.
Comment 4 Simon Fraser (smfr) 2013-03-07 21:59:57 PST 
I think always clearing the image is fine.
Comment 5 Tim Horton 2013-03-07 22:00:59 PST 
Created attachment 192145 [details]
patch
Comment 6 Tim Horton 2013-03-10 23:32:26 PDT 
http://trac.webkit.org/changeset/145341