Bug 111809 – [chromium] Delete code behind if (!applyXYZScaleInCompositor)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alexandre Elias]

[chromium] Delete code behind if (!applyXYZScaleInCompositor)

[Alexandre Elias]

Created attachment 192135 [details]
Patch

[Alexandre Elias]

Hi Adam, just a no-op cleanup patch.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 192135 [details]
Patch

Attachment 192135 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16987333

[Peter Beverloo (cr-android ews)]

Comment on attachment 192135 [details]
Patch

Attachment 192135 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/16991478

[WebKit Review Bot]

Comment on attachment 192135 [details]
Patch

Attachment 192135 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16991482

[James Robinson]

Comment on attachment 192135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192135&action=review

> Source/Platform/chromium/public/WebInputHandlerClient.h:59
> +    virtual bool scrollByIfPossible(WebPoint origin, WebFloatSize delta) = 0;

Looks like there isn't any implementation of this on the chromium side.  Has this not landed yet or does Source/WebKit/chromium/DEPS just need to be updated?

[Alexandre Elias]

It's just a Source/WebKit/chromium/DEPS problem, I guess I'll wait until it rolls then land this.

[James Robinson]

Feel free to roll it forward yourself as well.  It won't roll itself :)

[Adam Barth]

Comment on attachment 192135 [details]
Patch

<3

[Alexandre Elias]

Created attachment 192320 [details]
Patch

Reupload without changes to retry EWS bots

[Alexandre Elias]

Created attachment 192321 [details]
Patch

Rebase to 145298

[Alexandre Elias]

Created attachment 192324 [details]
Patch for landing

[Build Bot]

Comment on attachment 192324 [details]
Patch for landing

Attachment 192324 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17050904

New failing tests:
editing/selection/selection-modify-crash.html

[WebKit Review Bot]

Comment on attachment 192324 [details]
Patch for landing

Attachment 192324 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16997389

New failing tests:
platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/events/scale-and-scroll-iframe-window.html
fast/frames/frame-set-scaling-hit.html
fast/repaint/background-scaling.html
compositing/layer-creation/fixed-position-out-of-view-scaled.html
fast/frames/frame-set-rotation-hit.html
inspector/elements/highlight-node-scaled.html
fast/repaint/fixed-right-in-page-scale.html
compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
fast/events/scale-and-scroll-window.html
platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
fast/repaint/fixed-right-bottom-in-page-scale.html
platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html
fast/events/scale-and-scroll-body.html
fast/events/scale-and-scroll-iframe-body.html
svg/as-image/image-respects-pageScaleFactor.html
fast/repaint/fixed-in-page-scale.html
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
fast/repaint/scale-page-shrink.html

[Alexandre Elias]

Created attachment 195828 [details]
Patch

Hook in tests properly

[Alexandre Elias]

Sorry for the delay, just got back to this.  I took a close look at the layout test failures and hooked them in properly so that the scale is actually applied in all cases.  There were still a number of failures for various reasons (mostly iframes), I added them to the expectations and filed http://crbug.com/225184

[WebKit Review Bot]

Comment on attachment 195828 [details]
Patch

Attachment 195828 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17322400

New failing tests:
platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled.html

[WebKit Review Bot]

Created attachment 195832 [details]
Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Adam Barth]

Comment on attachment 195828 [details]
Patch

Looks like you still have some layout test failures to work through.

[Alexandre Elias]

Created attachment 195866 [details]
Patch

Add 2 more failing expectations

[Adam Barth]

Comment on attachment 195866 [details]
Patch

Looks like the bubbles are green.

[WebKit Review Bot]

Comment on attachment 195866 [details]
Patch

Clearing flags on attachment: 195866

Committed r147357: <http://trac.webkit.org/changeset/147357>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.