Bug 111809 - [chromium] Delete code behind if (!applyXYZScaleInCompositor)
Summary: [chromium] Delete code behind if (!applyXYZScaleInCompositor)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 19:42 PST by Alexandre Elias
Modified: 2013-04-01 13:47 PDT (History)
12 users (show)

See Also:


Attachments
Patch (41.67 KB, patch)
2013-03-07 20:04 PST, Alexandre Elias
no flags Details | Formatted Diff | Diff
Patch (41.69 KB, patch)
2013-03-08 18:34 PST, Alexandre Elias
no flags Details | Formatted Diff | Diff
Patch (40.91 KB, patch)
2013-03-08 18:40 PST, Alexandre Elias
no flags Details | Formatted Diff | Diff
Patch for landing (40.91 KB, patch)
2013-03-08 18:51 PST, Alexandre Elias
no flags Details | Formatted Diff | Diff
Patch (47.64 KB, patch)
2013-03-29 17:37 PDT, Alexandre Elias
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64 (1.58 MB, application/zip)
2013-03-29 18:25 PDT, WebKit Review Bot
no flags Details
Patch (47.90 KB, patch)
2013-03-30 13:04 PDT, Alexandre Elias
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2013-03-07 19:42:22 PST
[chromium] Delete code behind if (!applyXYZScaleInCompositor)
Comment 1 Alexandre Elias 2013-03-07 20:04:35 PST
Created attachment 192135 [details]
Patch
Comment 2 Alexandre Elias 2013-03-07 20:06:32 PST
Hi Adam, just a no-op cleanup patch.
Comment 3 WebKit Review Bot 2013-03-07 20:07:55 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2013-03-07 20:13:55 PST
Comment on attachment 192135 [details]
Patch

Attachment 192135 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16987333
Comment 5 Peter Beverloo (cr-android ews) 2013-03-07 20:22:52 PST
Comment on attachment 192135 [details]
Patch

Attachment 192135 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/16991478
Comment 6 WebKit Review Bot 2013-03-07 20:26:59 PST
Comment on attachment 192135 [details]
Patch

Attachment 192135 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16991482
Comment 7 James Robinson 2013-03-07 20:34:05 PST
Comment on attachment 192135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192135&action=review

> Source/Platform/chromium/public/WebInputHandlerClient.h:59
> +    virtual bool scrollByIfPossible(WebPoint origin, WebFloatSize delta) = 0;

Looks like there isn't any implementation of this on the chromium side.  Has this not landed yet or does Source/WebKit/chromium/DEPS just need to be updated?
Comment 8 Alexandre Elias 2013-03-07 20:39:56 PST
It's just a Source/WebKit/chromium/DEPS problem, I guess I'll wait until it rolls then land this.
Comment 9 James Robinson 2013-03-07 20:47:06 PST
Feel free to roll it forward yourself as well.  It won't roll itself :)
Comment 10 Adam Barth 2013-03-08 11:41:17 PST
Comment on attachment 192135 [details]
Patch

<3
Comment 11 Alexandre Elias 2013-03-08 18:34:53 PST
Created attachment 192320 [details]
Patch

Reupload without changes to retry EWS bots
Comment 12 Alexandre Elias 2013-03-08 18:40:32 PST
Created attachment 192321 [details]
Patch

Rebase to 145298
Comment 13 Alexandre Elias 2013-03-08 18:51:06 PST
Created attachment 192324 [details]
Patch for landing
Comment 14 Build Bot 2013-03-09 04:09:01 PST
Comment on attachment 192324 [details]
Patch for landing

Attachment 192324 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17050904

New failing tests:
editing/selection/selection-modify-crash.html
Comment 15 WebKit Review Bot 2013-03-09 06:41:08 PST
Comment on attachment 192324 [details]
Patch for landing

Attachment 192324 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16997389

New failing tests:
platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/events/scale-and-scroll-iframe-window.html
fast/frames/frame-set-scaling-hit.html
fast/repaint/background-scaling.html
compositing/layer-creation/fixed-position-out-of-view-scaled.html
fast/frames/frame-set-rotation-hit.html
inspector/elements/highlight-node-scaled.html
fast/repaint/fixed-right-in-page-scale.html
compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
fast/events/scale-and-scroll-window.html
platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
fast/repaint/fixed-right-bottom-in-page-scale.html
platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html
fast/events/scale-and-scroll-body.html
fast/events/scale-and-scroll-iframe-body.html
svg/as-image/image-respects-pageScaleFactor.html
fast/repaint/fixed-in-page-scale.html
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
fast/repaint/scale-page-shrink.html
Comment 16 Alexandre Elias 2013-03-29 17:37:39 PDT
Created attachment 195828 [details]
Patch

Hook in tests properly
Comment 17 Alexandre Elias 2013-03-29 17:41:24 PDT
Sorry for the delay, just got back to this.  I took a close look at the layout test failures and hooked them in properly so that the scale is actually applied in all cases.  There were still a number of failures for various reasons (mostly iframes), I added them to the expectations and filed http://crbug.com/225184
Comment 18 WebKit Review Bot 2013-03-29 18:24:56 PDT
Comment on attachment 195828 [details]
Patch

Attachment 195828 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17322400

New failing tests:
platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled.html
Comment 19 WebKit Review Bot 2013-03-29 18:25:00 PDT
Created attachment 195832 [details]
Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 20 Adam Barth 2013-03-30 10:47:31 PDT
Comment on attachment 195828 [details]
Patch

Looks like you still have some layout test failures to work through.
Comment 21 Alexandre Elias 2013-03-30 13:04:03 PDT
Created attachment 195866 [details]
Patch

Add 2 more failing expectations
Comment 22 Adam Barth 2013-03-30 14:25:25 PDT
Comment on attachment 195866 [details]
Patch

Looks like the bubbles are green.
Comment 23 WebKit Review Bot 2013-04-01 13:47:14 PDT
Comment on attachment 195866 [details]
Patch

Clearing flags on attachment: 195866

Committed r147357: <http://trac.webkit.org/changeset/147357>
Comment 24 WebKit Review Bot 2013-04-01 13:47:19 PDT
All reviewed patches have been landed.  Closing bug.