Bug 111806 - Add Nils Barth and Koji Hara to committers.py as Contributor
Summary: Add Nils Barth and Koji Hara to committers.py as Contributor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 18:37 PST by Nils Barth
Modified: 2013-03-07 21:15 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2013-03-07 18:38 PST, Nils Barth 		no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2013-03-07 19:00 PST, Nils Barth 		dpranke: review+
eric: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nils Barth 2013-03-07 18:37:23 PST 
Add Nils Barth and Koji Hara to committers.py
Comment 1 Nils Barth 2013-03-07 18:38:07 PST 
Created attachment 192125 [details]
Patch
Comment 2 Dirk Pranke 2013-03-07 18:46:18 PST 
Comment on attachment 192125 [details]
Patch

Historically we have each committer had themselves individually and then commit the file directly (not using the cq), so that we can be sure the access controls are working.

Can you please delete koji hara and have them submit their own change?
Comment 3 Nils Barth 2013-03-07 19:00:23 PST 
Created attachment 192127 [details]
Patch
Comment 4 Nils Barth 2013-03-07 19:02:35 PST 
(In reply to comment #2)
> (From update of attachment 192125 [details])
> Historically we have each committer had themselves individually and then commit the file directly (not using the cq), so that we can be sure the access controls are working.

I'm only adding myself as a Contributor (for autocomplete etc.), not a Committer, so I can't commit the file myself, so I'll need a cq? as well.
(Once I'll submit a separate patch to move myself to Committer instead.)

> Can you please delete koji hara and have them submit their own change?

Done!

Thanks for explaining!
Comment 5 Dirk Pranke 2013-03-07 19:21:13 PST 
Comment on attachment 192127 [details]
Patch

thanks! as mentioned previously, please try to land this directly rather than using the CQ.
Comment 6 Eric Seidel (no email) 2013-03-07 19:37:27 PST 
Comment on attachment 192127 [details]
Patch

The "don't use the commit-queue" concern is about adding Committers and Reviewers is my understanding.
Comment 7 Eric Seidel (no email) 2013-03-07 19:37:41 PST 
Comment on attachment 192125 [details]
Patch

This patch would have been fine too.
Comment 8 Eric Seidel (no email) 2013-03-07 19:38:32 PST 
Comment on attachment 192125 [details]
Patch

Dirk is correct in parrotting the party line.  But the party line only applies to Committer/Reviewer changes is my understanding.  Thank you all!
Comment 9 Eric Seidel (no email) 2013-03-07 19:38:46 PST 
Comment on attachment 192127 [details]
Patch

We'll try and land the bigger one for now.
Comment 10 WebKit Review Bot 2013-03-07 19:55:44 PST 
Comment on attachment 192125 [details]
Patch

Rejecting attachment 192125 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 192125, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-commit-queue.appspot.com/results/17066262
Comment 11 WebKit Review Bot 2013-03-07 20:31:42 PST 
Comment on attachment 192125 [details]
Patch

Clearing flags on attachment: 192125

Committed r145176: <http://trac.webkit.org/changeset/145176>
Comment 12 WebKit Review Bot 2013-03-07 20:31:46 PST 
All reviewed patches have been landed.  Closing bug.