Bug 111801 - Clean up NetworkProcess includes
Summary: Clean up NetworkProcess includes
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2013-03-07 17:35 PST by Alexey Proskuryakov
Modified: 2013-03-07 23:19 PST (History)
1 user (show)

See Also:

proposed patch (6.84 KB, patch)
2013-03-07 17:37 PST, Alexey Proskuryakov
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-03-07 17:35:31 PST
Move unnecessary includes out of headers.
Comment 1 Alexey Proskuryakov 2013-03-07 17:37:42 PST
Created attachment 192117 [details]
proposed patch
Comment 2 WebKit Review Bot 2013-03-07 17:39:35 PST
Attachment 192117 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/NetworkProcess/SchedulableLoader.cpp', u'Source/WebKit2/NetworkProcess/SchedulableLoader.h', u'Source/WebKit2/NetworkProcess/SyncNetworkResourceLoader.cpp']" exit_code: 1
Source/WebKit2/NetworkProcess/SyncNetworkResourceLoader.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2013-03-07 19:52:49 PST
Comment on attachment 192117 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192117&action=review


>> Source/WebKit2/NetworkProcess/SyncNetworkResourceLoader.cpp:36
>>  #include <WebCore/ResourceResponse.h>
>> +#include <WebCore/ResourceHandle.h>
> Alphabetical sorting problem.  [build/include_order] [4]

Switch the order here, please.
Comment 4 Alexey Proskuryakov 2013-03-07 23:19:44 PST
Committed <http://trac.webkit.org/r145184>.