RESOLVED FIXED 111801
Clean up NetworkProcess includes 
https://bugs.webkit.org/show_bug.cgi?id=111801
Summary Clean up NetworkProcess includes
Alexey Proskuryakov
Reported 2013-03-07 17:35:31 PST
Move unnecessary includes out of headers.
Attachments
proposed patch (6.84 KB, patch)
2013-03-07 17:37 PST, Alexey Proskuryakov 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-03-07 17:37:42 PST
Created attachment 192117 [details] proposed patch
WebKit Review Bot
Comment 2 2013-03-07 17:39:35 PST
Attachment 192117 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/NetworkProcess/SchedulableLoader.cpp', u'Source/WebKit2/NetworkProcess/SchedulableLoader.h', u'Source/WebKit2/NetworkProcess/SyncNetworkResourceLoader.cpp']" exit_code: 1 Source/WebKit2/NetworkProcess/SyncNetworkResourceLoader.cpp:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2013-03-07 19:52:49 PST
Comment on attachment 192117 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=192117&action=review r=me >> Source/WebKit2/NetworkProcess/SyncNetworkResourceLoader.cpp:36 >> #include <WebCore/ResourceResponse.h> >> +#include <WebCore/ResourceHandle.h> > > Alphabetical sorting problem. [build/include_order] [4] Switch the order here, please.
Alexey Proskuryakov
Comment 4 2013-03-07 23:19:44 PST
Committed <http://trac.webkit.org/r145184>.
Note You need to log in before you can comment on or make changes to this bug.