Bug 111793 – (tests) make nodesFromRect.js print a list of nodes that were found

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Christian Biesinger]

(tests) make nodesFromRect.js print a list of nodes that were found

[Christian Biesinger]

Created attachment 192104 [details]
Patch

[Antonio Gomes]

Comment on attachment 192104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192104&action=review

> LayoutTests/fast/dom/nodesFromRect/resources/nodesFromRect.js:21
> +    for (var i = 0; i < nodes.length; i++) {

I would have omitted the {}

[Allan Sandfeld Jensen]

Comment on attachment 192104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192104&action=review

> LayoutTests/fast/dom/nodesFromRect/resources/nodesFromRect.js:23
>    if (nodes.length != list.length) {
> +    var foundNodes = [];
> +    for (var i = 0; i < nodes.length; i++) {
> +      foundNodes.push(nodes[i].localName);
> +    }

Couldn't you move the logic that makes a string out of a list of nodes from nodesFromRectAsString to a separate method, and reuse that? It would give you more than the localname.

[Christian Biesinger]

Comment on attachment 192104 [details]
Patch

Nice! I didn't notice that prettyprinting code there. I'll reuse it.

[Christian Biesinger]

Created attachment 192235 [details]
Patch

[Allan Sandfeld Jensen]

Comment on attachment 192235 [details]
Patch

LGTM

[WebKit Review Bot]

Comment on attachment 192235 [details]
Patch

Clearing flags on attachment: 192235

Committed r145364: <http://trac.webkit.org/changeset/145364>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.