Bug 111791 - [chromium] Use SkMatrix44 instead of WebTransformationMatrix in animation APIs
Summary: [chromium] Use SkMatrix44 instead of WebTransformationMatrix in animation APIs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 16:25 PST by James Robinson
Modified: 2013-03-11 17:47 PDT (History)
10 users (show)

See Also:

Attachments
Patch (26.43 KB, patch)
2013-03-07 16:30 PST, James Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-03-07 16:25:15 PST 
[chromium] Use SkMatrix44 instead of WebTransformationMatrix in animation APIs
Comment 1 James Robinson 2013-03-07 16:30:32 PST 
Created attachment 192103 [details]
Patch
Comment 2 James Robinson 2013-03-07 16:31:49 PST 
This depends on https://codereview.chromium.org/12629006/.

Ian/Shawn - if you want to optimize the TransformationMatrix -> SkMatrix44 conversion it's now in its own file that can be easily hit in unit tests.
Comment 3 WebKit Review Bot 2013-03-07 16:38:08 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2013-03-07 16:46:12 PST 
Comment on attachment 192103 [details]
Patch

Attachment 192103 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17081209
Comment 5 Peter Beverloo (cr-android ews) 2013-03-07 17:04:56 PST 
Comment on attachment 192103 [details]
Patch

Attachment 192103 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17087072
Comment 6 WebKit Review Bot 2013-03-07 18:12:55 PST 
Comment on attachment 192103 [details]
Patch

Attachment 192103 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17066222
Comment 7 Adrienne Walker 2013-03-11 14:45:01 PDT 
Comment on attachment 192103 [details]
Patch

R=me.
Comment 8 James Robinson 2013-03-11 15:11:45 PDT 
Comment on attachment 192103 [details]
Patch

DEPS is >= 186902
Comment 9 WebKit Review Bot 2013-03-11 17:47:45 PDT 
Comment on attachment 192103 [details]
Patch

Clearing flags on attachment: 192103

Committed r145442: <http://trac.webkit.org/changeset/145442>
Comment 10 WebKit Review Bot 2013-03-11 17:47:49 PDT 
All reviewed patches have been landed.  Closing bug.