Bug 111769 - Add some Windows symbols that were missing in r145119
Summary: Add some Windows symbols that were missing in r145119
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 13:02 PST by Mark Hahnenberg
Modified: 2013-03-07 14:00 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2013-03-07 13:04 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
build fix (2.45 KB, patch)
2013-03-07 13:28 PST, Roger Fong 		mhahnenberg: commit-queue-
Details | Formatted Diff | Diff
build fix (2.45 KB, patch)
2013-03-07 13:41 PST, Roger Fong 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-03-07 13:02:32 PST 
Title says it all.
Comment 1 Mark Hahnenberg 2013-03-07 13:04:11 PST 
Created attachment 192073 [details]
Patch
Comment 2 Roger Fong 2013-03-07 13:28:28 PST 
Created attachment 192078 [details]
build fix

I also moved PropertyTable.cpp into the right solution folder cuz it was just hanging out in the JSC root solution folder.
Comment 3 Mark Hahnenberg 2013-03-07 13:34:11 PST 
Looks like we need a rebase here.
Comment 4 Roger Fong 2013-03-07 13:40:16 PST 
ugh vcproj file patches never seem to apply properly.
I'll update and upload a new one but I might just have to land it manually...
Comment 5 Mark Hahnenberg 2013-03-07 13:40:52 PST 
(In reply to comment #4)
> ugh vcproj file patches never seem to apply properly.
> I'll update and upload a new one but I might just have to land it manually...

That's fine, since it's just a build fix.
Comment 6 Roger Fong 2013-03-07 13:41:23 PST 
Created attachment 192080 [details]
build fix

I think this one might be exactly the same as the last...
Comment 7 Roger Fong 2013-03-07 13:42:31 PST 
landed http://trac.webkit.org/changeset/145129
Comment 8 Mark Hahnenberg 2013-03-07 14:00:34 PST 
Build looks good now.