Bug 111755 – AX: Can't activate links with VoiceOver in Safari

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

1. open mail.google.com in safari 
2. navigate to your list of messages 
3. either tab or VO navigate to the link for the message just after the check box for that message and VO press on it
4. you hear "AX scroll to visible link" but nothing happens 
I am not attaching an archive to this message as it contains personal data however it should be easily reproducible

[chris fleizach]

The order of the accessibility actions is apparently very important. We moved the Press action in the list to item 3, and hence the problems

[chris fleizach]

Created attachment 192049 [details]
patch

[chris fleizach]

adding tim to help with review

[Tim Horton]

View in context: https://bugs.webkit.org/attachment.cgi?id=192049&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:921
> +    // Action elements allow Press. Order is very important. Press needs to be first.

This really needs a "why".

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:1069
> +#endif // PLATFORM(MAC) && !PLATFORM(IOS)

This is a short enough block, we don't need to repeat the condition.

[chris fleizach]

(In reply to comment #4)
> View in context: https://bugs.webkit.org/attachment.cgi?id=192049&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:921
> > +    // Action elements allow Press. Order is very important. Press needs to be first.
> 
> This really needs a "why".
> 
> > Tools/DumpRenderTree/AccessibilityUIElement.cpp:1069
> > +#endif // PLATFORM(MAC) && !PLATFORM(IOS)
> 
> This is a short enough block, we don't need to repeat the condition.

Will fix. Thanks

[chris fleizach]

http://trac.webkit.org/changeset/145116

[Ryosuke Niwa]

The test added by this patch as been failing on WebKit2:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=platform%2Fmac%2Faccessibility%2Fpress-action-is-first.html

[chris fleizach]

(In reply to comment #7)
> The test added by this patch as been failing on WebKit2:
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=platform%2Fmac%2Faccessibility%2Fpress-action-is-first.html

I'll add a patch tonight
Forgot to add a method to WebKitTestRunner