Bug 111736 - [Qt] Enable tiled shadow blur for inset box shadows
Summary: [Qt] Enable tiled shadow blur for inset box shadows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks: 90082
  Show dependency tree / graph
 
Reported: 2013-03-07 08:51 PST by Allan Sandfeld Jensen
Modified: 2013-04-30 05:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.79 KB, patch)
2013-03-07 08:56 PST, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Patch (4.52 KB, patch)
2013-03-07 09:03 PST, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Patch (4.87 KB, patch)
2013-03-08 09:56 PST, Allan Sandfeld Jensen 		noam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-03-07 08:51:41 PST 
Inset box-shadows are currently painting by applying generic shadow blur to the entire rect instead of using the optimized tiled shadow blur.

This affects common pastebin sites that has a inset box-shadows around the entire shown paste.
Comment 1 Allan Sandfeld Jensen 2013-03-07 08:56:07 PST 
Created attachment 192011 [details]
Patch
Comment 2 Allan Sandfeld Jensen 2013-03-07 09:03:01 PST 
Created attachment 192012 [details]
Patch
Comment 3 Allan Sandfeld Jensen 2013-03-08 09:56:14 PST 
Created attachment 192243 [details]
Patch

Avoid copying fill-color by just calling clearShadow later
Comment 4 Allan Sandfeld Jensen 2013-03-11 08:45:15 PDT 
Committed r145366: <http://trac.webkit.org/changeset/145366>