Bug 111733 – [BlackBerry] Prevent text selection inside Colour and Date/Time input fields

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Mike Fenton]

BlackBerry port uses button rendering and popups for input, text selection should not be allowed.

[Mike Fenton]

Created attachment 192004 [details]
Patch

Internal Reviewer: Me r+. Looks good.

[Rob Buis]

Comment on attachment 192004 [details]
Patch

LGTM.

[Mike Fenton]

Created attachment 192055 [details]
Patch with reviewers denoted.

[WebKit Review Bot]

Comment on attachment 192055 [details]
Patch with reviewers denoted.

Clearing flags on attachment: 192055

Committed r145121: <http://trac.webkit.org/changeset/145121>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Mike Fenton]

Created attachment 192764 [details]
Additional Patch.

[Mike Fenton]

Re-opening for additional case.

I prefer not to do nested if statements but the logic is sound whatever way you do it.
r+ with style improved.

[Mike Fenton]

Created attachment 192769 [details]
Replacement patch.

[Rob Buis]

Comment on attachment 192769 [details]
Replacement patch.

LGTM.

[WebKit Review Bot]

Comment on attachment 192769 [details]
Replacement patch.

Clearing flags on attachment: 192769

Committed r145571: <http://trac.webkit.org/changeset/145571>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alberto Garcia]

Created attachment 193105 [details]
Fix compilation error

+    if (Node* focusedNode = frame->document()->focusedNode()
+        && (focusedNode->hasTagName(HTMLNames::selectTag) || (focusedNode->isElementNode() && DOMSupport::isPopupInputField(toElement(focusedNode))))) {
+            SelectionLog(Platform::LogLevelInfo, "SelectionHandler::selectionPositionChanged selection is on a popup control, skipping rendering.");
+            return;
+        }
+    }

Uh, oh, there's one brace missing, this won't compile.

[Rob Buis]

Comment on attachment 193105 [details]
Fix compilation error

Well spotted.

[Alberto Garcia]

Do we need to reopen this bug in order to commit the patch?

[Rob Buis]

(In reply to comment #16)
> Do we need to reopen this bug in order to commit the patch?

Let's try without.

[Alberto Garcia]

(In reply to comment #17)
> (In reply to comment #16)
> > Do we need to reopen this bug in order to commit the patch?
> 
> Let's try without.

It didn't seem to work :)

[Mike Fenton]

Re-opening to land patch.

[WebKit Review Bot]

Comment on attachment 193105 [details]
Fix compilation error

Clearing flags on attachment: 193105

Committed r146092: <http://trac.webkit.org/changeset/146092>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.