Bug 111719 – Web Inspector: Flame Chart. Draw items according to the timeline.

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

The items in the CPUProfile are sorted by time of first invocation.
The paint function receives them from latest to earliest but paints them from left to right.
This will confuse the developers. So we need to change the painting position.

We could change the visiting order but the algorithm would require more memory or would produce more garbage in that case.
So I prefer to change the paint procedure.

[Ilya Tikhonovsky]

Created attachment 191983 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #0)
> We could change the visiting order but the algorithm would require more memory or would produce more garbage in that case.
> So I prefer to change the paint procedure.

Why would it require more memory? Isn't it enough to simply change the order in which we push node's children on the stack?

[Yury Semikhatsky]

Comment on attachment 191983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191983&action=review

> Source/WebCore/inspector/front-end/FlameChart.js:205
> +                    height: this._yScaleFactor,

Please rename _yScaleFactor to _barHeight

[Ilya Tikhonovsky]

Created attachment 192414 [details]
Patch

[Ilya Tikhonovsky]

(In reply to comment #3)
> (From update of attachment 191983 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191983&action=review
> 
> > Source/WebCore/inspector/front-end/FlameChart.js:205
> > +                    height: this._yScaleFactor,
> 
> Please rename _yScaleFactor to _barHeight

done

[Build Bot]

Comment on attachment 192414 [details]
Patch

Attachment 192414 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17024268

New failing tests:
fast/css/sticky/inline-sticky.html

[Ilya Tikhonovsky]

obsolete