Bug 111717 - Web Inspector: [CodeMirror] set indentation size according to devtools settings
Summary: Web Inspector: [CodeMirror] set indentation size according to devtools settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 05:58 PST by Andrey Lushnikov
Modified: 2013-03-11 08:51 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2013-03-07 06:00 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-03-07 05:58:06 PST 
Set indentation size in CodeMirror experiment according to devtools settings.
Comment 1 Andrey Lushnikov 2013-03-07 06:00:48 PST 
Created attachment 191982 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-03-07 08:09:57 PST 
Comment on attachment 191982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191982&action=review

> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:59
> +    if (indent === WebInspector.TextUtils.Indent.TabCharacter) {

WebInspector.TextUtils.Indent is undefined
Comment 3 Andrey Lushnikov 2013-03-07 09:49:33 PST 
Comment on attachment 191982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191982&action=review

>> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:59
>> +    if (indent === WebInspector.TextUtils.Indent.TabCharacter) {
> 
> WebInspector.TextUtils.Indent is undefined

It was introduced here: https://bugs.webkit.org/show_bug.cgi?id=111715
Comment 4 WebKit Review Bot 2013-03-11 08:51:42 PDT 
Comment on attachment 191982 [details]
Patch

Clearing flags on attachment: 191982

Committed r145368: <http://trac.webkit.org/changeset/145368>
Comment 5 WebKit Review Bot 2013-03-11 08:51:45 PDT 
All reviewed patches have been landed.  Closing bug.