[WK2][EFL] Fix EwkContext class API

[Mikhail Pozdnyakov]

EwkContext class has couple of problems to be fixed:
1) EwkContext::create() should be called getOrCreate actually, as it returns the same instance of EwkContext for the given WKContextRef if present.
2) EwkContext::defaultContext() should return raw pointer rather than PassRefPtr<EwkContext> as ownership is not transferred there.

[Mikhail Pozdnyakov]

Created attachment 191964 [details]
patch

[Kenneth Rohde Christiansen]

Comment on attachment 191964 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191964&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:105
> +PassRefPtr<EwkContext> EwkContext::getOrCreate(WKContextRef context)

I really dislike the name! Ain't there examples of similar things in WebCore

[Mikhail Pozdnyakov]

Created attachment 191974 [details]
patch v2

renamed getOrCreate(). Default context is created after main() entrance :)

[Kenneth Rohde Christiansen]

Comment on attachment 191974 [details]
patch v2

LGTM

[Alexey Proskuryakov]

Comment on attachment 191974 [details]
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=191974&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:132
> +    static EwkContext* defaultInstance = 0;
> +    if (!defaultInstance)
> +        defaultInstance = create().leakRef();

A better way to write this would be:

static EwkContext* defaultInstance = create().leakRef();

[Mikhail Pozdnyakov]

Created attachment 192713 [details]
to be landed

[WebKit Review Bot]

Comment on attachment 192713 [details]
to be landed

Clearing flags on attachment: 192713

Committed r145535: <http://trac.webkit.org/changeset/145535>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.