Bug 111698 - Web Inspector: Change profile start button caption depending on profile type
Summary: Web Inspector: Change profile start button caption depending on profile type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexei Filippov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 01:44 PST by Alexei Filippov
Modified: 2013-03-07 07:30 PST (History)
9 users (show)

See Also:


Attachments
Patch (6.70 KB, patch)
2013-03-07 01:48 PST, Alexei Filippov
no flags Details | Formatted Diff | Diff
Patch (7.52 KB, patch)
2013-03-07 04:04 PST, Alexei Filippov
no flags Details | Formatted Diff | Diff
Patch (7.61 KB, patch)
2013-03-07 06:06 PST, Alexei Filippov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Filippov 2013-03-07 01:44:18 PST
For CPU like profile types the current "Start/Stop" buttons is ok. While for heap snapshot like profiles that do not start a continuous action change the button caption to "Snapshot".
Comment 1 Alexei Filippov 2013-03-07 01:48:20 PST
Created attachment 191950 [details]
Patch
Comment 2 Alexei Filippov 2013-03-07 04:04:44 PST
Created attachment 191965 [details]
Patch
Comment 3 Yury Semikhatsky 2013-03-07 05:05:47 PST
Comment on attachment 191965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191965&action=review

> Source/WebCore/inspector/front-end/ProfileLauncherView.js:75
> +            this._controlButton.textContent = WebInspector.UIString("Snapshot");

Take Snapshot or Capture?
Comment 4 Alexei Filippov 2013-03-07 06:06:43 PST
Created attachment 191984 [details]
Patch
Comment 5 Alexei Filippov 2013-03-07 06:08:16 PST
Comment on attachment 191965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191965&action=review

>> Source/WebCore/inspector/front-end/ProfileLauncherView.js:75
>> +            this._controlButton.textContent = WebInspector.UIString("Snapshot");
> 
> Take Snapshot or Capture?

Ok, let's go for "Take Snapshot" for now.
Comment 6 WebKit Review Bot 2013-03-07 07:30:41 PST
Comment on attachment 191984 [details]
Patch

Clearing flags on attachment: 191984

Committed r145074: <http://trac.webkit.org/changeset/145074>
Comment 7 WebKit Review Bot 2013-03-07 07:30:44 PST
All reviewed patches have been landed.  Closing bug.