Bug 111697 - Web Inspector: Flame Chart. Stick item color to the function.
Summary: Web Inspector: Flame Chart. Stick item color to the function.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 01:32 PST by Ilya Tikhonovsky
Modified: 2013-03-07 05:38 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2013-03-07 01:47 PST, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (5.08 KB, patch)
2013-03-07 04:36 PST, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-03-07 01:32:04 PST 
EOM
Comment 1 Ilya Tikhonovsky 2013-03-07 01:47:15 PST 
Created attachment 191949 [details]
Patch
Comment 2 Yury Semikhatsky 2013-03-07 04:25:06 PST 
Comment on attachment 191949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191949&action=review

> Source/WebCore/inspector/front-end/FlameChart.js:181
> +            var lightness = this._highlightedNode === node ? 33 : 67;

The color isn't restored when selected node changes. r- for this
Comment 3 Ilya Tikhonovsky 2013-03-07 04:36:16 PST 
Created attachment 191970 [details]
Patch
Comment 4 Ilya Tikhonovsky 2013-03-07 05:30:52 PST 
(In reply to comment #2)
> (From update of attachment 191949 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191949&action=review
> 
> > Source/WebCore/inspector/front-end/FlameChart.js:181
> > +            var lightness = this._highlightedNode === node ? 33 : 67;
> 
> The color isn't restored when selected node changes. r- for this

fixed
Comment 5 Ilya Tikhonovsky 2013-03-07 05:38:54 PST 
Committed r145065: <http://trac.webkit.org/changeset/145065>