WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111697
Web Inspector: Flame Chart. Stick item color to the function.
https://bugs.webkit.org/show_bug.cgi?id=111697
Summary
Web Inspector: Flame Chart. Stick item color to the function.
Ilya Tikhonovsky
Reported
2013-03-07 01:32:04 PST
EOM
Attachments
Patch
(5.19 KB, patch)
2013-03-07 01:47 PST
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
Patch
(5.08 KB, patch)
2013-03-07 04:36 PST
,
Ilya Tikhonovsky
yurys
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2013-03-07 01:47:15 PST
Created
attachment 191949
[details]
Patch
Yury Semikhatsky
Comment 2
2013-03-07 04:25:06 PST
Comment on
attachment 191949
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=191949&action=review
> Source/WebCore/inspector/front-end/FlameChart.js:181 > + var lightness = this._highlightedNode === node ? 33 : 67;
The color isn't restored when selected node changes. r- for this
Ilya Tikhonovsky
Comment 3
2013-03-07 04:36:16 PST
Created
attachment 191970
[details]
Patch
Ilya Tikhonovsky
Comment 4
2013-03-07 05:30:52 PST
(In reply to
comment #2
)
> (From update of
attachment 191949
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=191949&action=review
> > > Source/WebCore/inspector/front-end/FlameChart.js:181 > > + var lightness = this._highlightedNode === node ? 33 : 67; > > The color isn't restored when selected node changes. r- for this
fixed
Ilya Tikhonovsky
Comment 5
2013-03-07 05:38:54 PST
Committed
r145065
: <
http://trac.webkit.org/changeset/145065
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug