Bug 111689 - [WK2] SandboxExtension::createHandle raises an uncaught Objective-C exception if path is empty
Summary: [WK2] SandboxExtension::createHandle raises an uncaught Objective-C exception...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 23:14 PST by Alexey Proskuryakov
Modified: 2013-03-06 23:29 PST (History)
1 user (show)

See Also:


Attachments
proposed fix (1.76 KB, patch)
2013-03-06 23:17 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-03-06 23:14:01 PST
Calling fileSystemRepresentation on an empty NSString results in an exception.
Comment 1 Alexey Proskuryakov 2013-03-06 23:17:44 PST
Created attachment 191930 [details]
proposed fix
Comment 2 Filip Pizlo 2013-03-06 23:24:11 PST
Actually, am I allowed to review these patches?  I guess I'm not a WK2 reviewer.  Anyways, LGTM.
Comment 3 Filip Pizlo 2013-03-06 23:24:34 PST
Comment on attachment 191930 [details]
proposed fix

Resetting r? because I'm not a WK2 reviewer.
Comment 4 Filip Pizlo 2013-03-06 23:25:06 PST
Comment on attachment 191930 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=191930&action=review

> Source/WebKit2/ChangeLog:9
> +        Use a fucntion from WebCore platform layer instead of Foundation one equivalent.

s/fucntion/function
Comment 5 Alexey Proskuryakov 2013-03-06 23:29:01 PST
Ugh, I already committed before you undid the review. Probably not worth rolling out, as this implicitly has "WebKit2 owner approval".
Comment 6 Alexey Proskuryakov 2013-03-06 23:29:40 PST
Committed <http://trac.webkit.org/r145042>.