RESOLVED FIXED 111680
Web Inspector: Add shortcut for running a snippet. 
https://bugs.webkit.org/show_bug.cgi?id=111680
Summary Web Inspector: Add shortcut for running a snippet.
Vsevolod Vlasov
Reported 2013-03-06 21:35:10 PST
Patch to follow
Attachments
Patch (2.86 KB, patch)
2013-03-06 21:36 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2013-03-06 21:36:32 PST
Created attachment 191915 [details] Patch
Pavel Feldman
Comment 2 2013-03-06 21:44:23 PST
Comment on attachment 191915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191915&action=review > Source/WebCore/inspector/front-end/SnippetJavaScriptSourceFrame.js:46 > + var runSnippetShortcutDescriptor = WebInspector.KeyboardShortcut.makeDescriptor(WebInspector.KeyboardShortcut.Keys.Enter, WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta) Eclipse uses Ctrl+F11, Ctrl+F10 idea. > Source/WebCore/inspector/front-end/SnippetJavaScriptSourceFrame.js:72 > + _onKeyDown: function(event) I've seen this code. Should it be moved to View.js with corresponding registerShortcut(key, modifier, handler) ? I even thing handler should be unbound for the sake of performance.
Vsevolod Vlasov
Comment 3 2013-03-07 08:05:29 PST
Comment on attachment 191915 [details] Patch As discussed offline Ctrl+Enter is a more convenient shortcut which does not clash with anything that we already have or plan to have in near future. Shortcut handling requires a separate effort so let's keep things as is for now.
WebKit Review Bot
Comment 4 2013-03-08 07:13:40 PST
Comment on attachment 191915 [details] Patch Clearing flags on attachment: 191915 Committed r145218: <http://trac.webkit.org/changeset/145218>
WebKit Review Bot
Comment 5 2013-03-08 07:13:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.