Bug 111680 - Web Inspector: Add shortcut for running a snippet.
Summary: Web Inspector: Add shortcut for running a snippet.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 21:35 PST by Vsevolod Vlasov
Modified: 2013-03-08 07:13 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2013-03-06 21:36 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2013-03-06 21:35:10 PST 
Patch to follow
Comment 1 Vsevolod Vlasov 2013-03-06 21:36:32 PST 
Created attachment 191915 [details]
Patch
Comment 2 Pavel Feldman 2013-03-06 21:44:23 PST 
Comment on attachment 191915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191915&action=review

> Source/WebCore/inspector/front-end/SnippetJavaScriptSourceFrame.js:46
> +    var runSnippetShortcutDescriptor = WebInspector.KeyboardShortcut.makeDescriptor(WebInspector.KeyboardShortcut.Keys.Enter, WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta)

Eclipse uses Ctrl+F11, Ctrl+F10 idea.

> Source/WebCore/inspector/front-end/SnippetJavaScriptSourceFrame.js:72
> +    _onKeyDown: function(event)

I've seen this code. Should it be moved to View.js with corresponding registerShortcut(key, modifier, handler) ? I even thing handler should be unbound for the sake of performance.
Comment 3 Vsevolod Vlasov 2013-03-07 08:05:29 PST 
Comment on attachment 191915 [details]
Patch

As discussed offline Ctrl+Enter is a more convenient shortcut which does not clash with anything that we already have or plan to have in near future.
Shortcut handling requires a separate effort so let's keep things as is for now.
Comment 4 WebKit Review Bot 2013-03-08 07:13:40 PST 
Comment on attachment 191915 [details]
Patch

Clearing flags on attachment: 191915

Committed r145218: <http://trac.webkit.org/changeset/145218>
Comment 5 WebKit Review Bot 2013-03-08 07:13:44 PST 
All reviewed patches have been landed.  Closing bug.