Bug 111666 - Compute WebGL context attributes from DrawingBuffer when it is used
Summary: Compute WebGL context attributes from DrawingBuffer when it is used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 19:18 PST by Kenneth Russell
Modified: 2013-03-07 17:08 PST (History)
9 users (show)

See Also:


Attachments
Patch (2.19 KB, patch)
2013-03-07 12:58 PST, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2013-03-06 19:18:07 PST
On ports where WebGLRenderingContext's back buffer is managed by the DrawingBuffer class (Source/WebCore/platform/graphics/gpu/DrawingBuffer.h), WebGLRenderingContext::getContextAttributes should be implemented in terms of the DrawingBuffer, not GraphicsContext3D. This mismatch is causing conformance test failures on platforms which don't support multisampling, probably among other problems.
Comment 1 Kenneth Russell 2013-03-07 12:56:55 PST
After further examination, the DrawingBuffer determines all of its context creation attributes from the GraphicsContext3D. The only flag it determines itself is whether it can support multisampling based on the presence of the framebuffer_blit and framebuffer_multisample extensions. Fixing just the computation of the antialias flag.
Comment 2 Kenneth Russell 2013-03-07 12:58:56 PST
Created attachment 192071 [details]
Patch
Comment 3 WebKit Review Bot 2013-03-07 17:08:53 PST
Comment on attachment 192071 [details]
Patch

Clearing flags on attachment: 192071

Committed r145159: <http://trac.webkit.org/changeset/145159>
Comment 4 WebKit Review Bot 2013-03-07 17:08:57 PST
All reviewed patches have been landed.  Closing bug.