Don't give PageAllocationAligned the option to allocate executable memory
Created attachment 191881 [details] Patch
Comment on attachment 191881 [details] Patch r=me
Attachment 191881 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/PageAllocationAligned.cpp', u'Source/WTF/wtf/PageAllocationAligned.h']" exit_code: 1 Source/WTF/wtf/PageAllocationAligned.h:44: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/PageAllocationAligned.h:44: The parameter name "usage" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r145018: <http://trac.webkit.org/changeset/145018>
This change broke all the builds (because non Mac platforms used the boolean) but you never saw that because you didn't run the EWS. There is a patch to fix it in bug 111659. But it also broke Apple Win on top of it as the WTF exported symbol changed. Unless you fix this within 30 minutes, I will have to roll this change out.
> But it also broke Apple Win on top of it as the WTF exported symbol changed. > > Unless you fix this within 30 minutes, I will have to roll this change out. Actually scratch that, Ryosuke corrected me. It will be corrected by bug 111659. Thanks for wasting everybody's time.
(In reply to comment #6) > > But it also broke Apple Win on top of it as the WTF exported symbol changed. > > > > Unless you fix this within 30 minutes, I will have to roll this change out. > > Actually scratch that, Ryosuke corrected me. It will be corrected by bug 111659. Thanks for wasting everybody's time. That's the one of least professional comments i've seen yet. Obviously I did not deliberately break other builds (i thought i had removed the use of the executable parameter for other builds).