WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111657
Don't give PageAllocationAligned the option to allocate executable memory
https://bugs.webkit.org/show_bug.cgi?id=111657
Summary
Don't give PageAllocationAligned the option to allocate executable memory
Oliver Hunt
Reported
2013-03-06 18:11:38 PST
Don't give PageAllocationAligned the option to allocate executable memory
Attachments
Patch
(3.32 KB, patch)
2013-03-06 18:12 PST
,
Oliver Hunt
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2013-03-06 18:12:06 PST
Created
attachment 191881
[details]
Patch
Geoffrey Garen
Comment 2
2013-03-06 18:14:46 PST
Comment on
attachment 191881
[details]
Patch r=me
WebKit Review Bot
Comment 3
2013-03-06 18:15:49 PST
Attachment 191881
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/PageAllocationAligned.cpp', u'Source/WTF/wtf/PageAllocationAligned.h']" exit_code: 1 Source/WTF/wtf/PageAllocationAligned.h:44: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/PageAllocationAligned.h:44: The parameter name "usage" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 4
2013-03-06 18:16:34 PST
Committed
r145018
: <
http://trac.webkit.org/changeset/145018
>
Julien Chaffraix
Comment 5
2013-03-06 18:57:02 PST
This change broke all the builds (because non Mac platforms used the boolean) but you never saw that because you didn't run the EWS. There is a patch to fix it in
bug 111659
. But it also broke Apple Win on top of it as the WTF exported symbol changed. Unless you fix this within 30 minutes, I will have to roll this change out.
Julien Chaffraix
Comment 6
2013-03-06 19:00:23 PST
> But it also broke Apple Win on top of it as the WTF exported symbol changed. > > Unless you fix this within 30 minutes, I will have to roll this change out.
Actually scratch that, Ryosuke corrected me. It will be corrected by
bug 111659
. Thanks for wasting everybody's time.
Oliver Hunt
Comment 7
2013-03-06 20:04:15 PST
(In reply to
comment #6
)
> > But it also broke Apple Win on top of it as the WTF exported symbol changed. > > > > Unless you fix this within 30 minutes, I will have to roll this change out. > > Actually scratch that, Ryosuke corrected me. It will be corrected by
bug 111659
. Thanks for wasting everybody's time.
That's the one of least professional comments i've seen yet. Obviously I did not deliberately break other builds (i thought i had removed the use of the executable parameter for other builds).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug