Bug 111630 - [texmap] Remove direct access to clip state from clip stack
Summary: [texmap] Remove direct access to clip state from clip stack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bruno Abinader (history only)
URL:
Keywords:
Depends on: 111566
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-06 14:49 PST by Bruno Abinader (history only)
Modified: 2013-03-07 07:28 PST (History)
8 users (show)

See Also:


Attachments
Patch (5.25 KB, patch)
2013-03-06 14:54 PST, Bruno Abinader (history only)
no flags Details | Formatted Diff | Diff
Patch (5.36 KB, patch)
2013-03-07 06:54 PST, Bruno Abinader (history only)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Abinader (history only) 2013-03-06 14:49:32 PST
As we are now monitoring the clip state from TextureMapperGL/BitmapTextureGL, have direct access to clip state object would eventually make it dirty without properly setting the 'clipStateDirty' flag. This bug intends to substitute direct access with auxiliary functions which would set the clip state dirty when necessary.
Comment 1 Bruno Abinader (history only) 2013-03-06 14:54:09 PST
Created attachment 191836 [details]
Patch

Proposed patch
Comment 2 Bruno Abinader (history only) 2013-03-07 06:54:57 PST
Created attachment 191988 [details]
Patch

Rebased patch after changes from r145071
Comment 3 Allan Sandfeld Jensen 2013-03-07 07:04:13 PST
Comment on attachment 191988 [details]
Patch

LGTM
Comment 4 WebKit Review Bot 2013-03-07 07:27:58 PST
Comment on attachment 191988 [details]
Patch

Clearing flags on attachment: 191988

Committed r145073: <http://trac.webkit.org/changeset/145073>
Comment 5 WebKit Review Bot 2013-03-07 07:28:02 PST
All reviewed patches have been landed.  Closing bug.