Bug 111628 - [nrwt] handle corrupt http server pid files cleanly
Summary: [nrwt] handle corrupt http server pid files cleanly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords: NRWT
Depends on:
Blocks:
 
Reported: 2013-03-06 14:41 PST by Dirk Pranke
Modified: 2013-03-07 13:01 PST (History)
6 users (show)

See Also:


Attachments
Patch (8.24 KB, patch)
2013-03-06 14:42 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2013-03-06 14:41:29 PST
[nrwt] handle corrupt http server pid files cleanly
Comment 1 Dirk Pranke 2013-03-06 14:42:52 PST
Created attachment 191835 [details]
Patch
Comment 2 Dirk Pranke 2013-03-06 14:44:07 PST
Comment on attachment 191835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191835&action=review

> Tools/Scripts/webkitpy/layout_tests/servers/http_server_base.py:109
> +                    self._pid = actual_pid

It's unfortunate this block is almost completely duplicated between here and the above code, but there's no good way to share the logic as we need to ensure that the whole stop block is wrapped in the finally that deletes the file.
Comment 3 Dirk Pranke 2013-03-06 14:44:33 PST
See https://code.google.com/p/chromium/issues/detail?id=177798 for the motivating problem.
Comment 4 Eric Seidel (no email) 2013-03-06 19:38:11 PST
Comment on attachment 191835 [details]
Patch

Looks reasonable.  Thank you.
Comment 5 WebKit Review Bot 2013-03-07 13:01:01 PST
Comment on attachment 191835 [details]
Patch

Clearing flags on attachment: 191835

Committed r145122: <http://trac.webkit.org/changeset/145122>
Comment 6 WebKit Review Bot 2013-03-07 13:01:07 PST
All reviewed patches have been landed.  Closing bug.