WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111628
[nrwt] handle corrupt http server pid files cleanly
https://bugs.webkit.org/show_bug.cgi?id=111628
Summary
[nrwt] handle corrupt http server pid files cleanly
Dirk Pranke
Reported
2013-03-06 14:41:29 PST
[nrwt] handle corrupt http server pid files cleanly
Attachments
Patch
(8.24 KB, patch)
2013-03-06 14:42 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2013-03-06 14:42:52 PST
Created
attachment 191835
[details]
Patch
Dirk Pranke
Comment 2
2013-03-06 14:44:07 PST
Comment on
attachment 191835
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=191835&action=review
> Tools/Scripts/webkitpy/layout_tests/servers/http_server_base.py:109 > + self._pid = actual_pid
It's unfortunate this block is almost completely duplicated between here and the above code, but there's no good way to share the logic as we need to ensure that the whole stop block is wrapped in the finally that deletes the file.
Dirk Pranke
Comment 3
2013-03-06 14:44:33 PST
See
https://code.google.com/p/chromium/issues/detail?id=177798
for the motivating problem.
Eric Seidel (no email)
Comment 4
2013-03-06 19:38:11 PST
Comment on
attachment 191835
[details]
Patch Looks reasonable. Thank you.
WebKit Review Bot
Comment 5
2013-03-07 13:01:01 PST
Comment on
attachment 191835
[details]
Patch Clearing flags on attachment: 191835 Committed
r145122
: <
http://trac.webkit.org/changeset/145122
>
WebKit Review Bot
Comment 6
2013-03-07 13:01:07 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug