Bug 111620 - [GTK][WK2] Add webkit_uri_request_set_uri to WebKit2 GTK+ API
Summary: [GTK][WK2] Add webkit_uri_request_set_uri to WebKit2 GTK+ API
Status: RESOLVED DUPLICATE of bug 83681
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 13:43 PST by Manuel Rego Casasnovas
Modified: 2013-03-07 00:08 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.50 KB, patch)
2013-03-06 13:50 PST, Manuel Rego Casasnovas
cgarcia: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2013-03-06 13:43:23 PST
This is required to fix the following bug in Epiphany https://bugzilla.gnome.org/show_bug.cgi?id=695300
Comment 1 Manuel Rego Casasnovas 2013-03-06 13:50:07 PST
Created attachment 191825 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-06 13:58:17 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2013-03-06 23:11:35 PST
Comment on attachment 191825 [details]
Patch

Thanks for the patch, but this has already been added, see patch in bug #83681, it hasn't landed in trunk yet because it's waiting for a WebKit2 owner, but landed in the stable branch already. In any case your patch has some issues, you are allowing the API to modify a construct only property, you should change the property to not be construct only, and use webkit_uri_request_set_uri()in the GObject setter too, emitting the notify signal when it changes.
Comment 4 Manuel Rego Casasnovas 2013-03-07 00:08:38 PST
(In reply to comment #3)
> (From update of attachment 191825 [details])
> Thanks for the patch, but this has already been added, see patch in bug #83681, it hasn't landed in trunk yet because it's waiting for a WebKit2 owner, but landed in the stable branch already. In any case your patch has some issues, you are allowing the API to modify a construct only property, you should change the property to not be construct only, and use webkit_uri_request_set_uri()in the GObject setter too, emitting the notify signal when it changes.

Ok, sorry for the noise then. Closing as duplicated.

*** This bug has been marked as a duplicate of bug 83681 ***