Bug 111618 - [BlackBerry] Selection handles don't drag to expand correctly for RTL languages
Summary: [BlackBerry] Selection handles don't drag to expand correctly for RTL languages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 13:13 PST by Nima Ghanavatian
Modified: 2013-03-06 14:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.67 KB, patch)
2013-03-06 13:15 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (2.72 KB, patch)
2013-03-06 13:32 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2013-03-06 13:13:46 PST 
SSIA
Comment 1 Nima Ghanavatian 2013-03-06 13:15:04 PST 
Created attachment 191816 [details]
Patch
Comment 2 Mike Fenton 2013-03-06 13:19:05 PST 
Comment on attachment 191816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191816&action=review

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:76
> +    , m_isDirectionalOffsetSetToRTL(false)

Is this variable needed?  It's not used in this patch.
Comment 3 Nima Ghanavatian 2013-03-06 13:32:22 PST 
Created attachment 191820 [details]
Patch
Comment 4 Rob Buis 2013-03-06 13:39:38 PST 
Comment on attachment 191820 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2013-03-06 14:14:30 PST 
Comment on attachment 191820 [details]
Patch

Clearing flags on attachment: 191820

Committed r144977: <http://trac.webkit.org/changeset/144977>
Comment 6 WebKit Review Bot 2013-03-06 14:14:33 PST 
All reviewed patches have been landed.  Closing bug.