Bug 111586 – SVG pattern to pattern reference does not work if first pattern has a child node

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

Created attachment 191759 [details]
Not working pattern to pattern reference

The following simple reference of another pattern does not work:

<pattern xlink:href="#pattern2" id="pattern1">
</pattern>

I assume this is because of the newline that creates a TextNode. With this node we do not reference the second pattern anymore. The following does work:

<pattern xlink:href="#pattern2" id="pattern1"></pattern>

Adobe Illustrator exports the first example, why often patterns don't work exported from Illustrator.

[Florin Malita]

Created attachment 191766 [details]
Patch

[Philip Rogers]

Comment on attachment 191766 [details]
Patch

This change is very reasonable.

Do you mind checking that the ~20 other instances of hasChildNodes() do not have the same problem?

[Florin Malita]

(In reply to comment #2)
> (From update of attachment 191766 [details])
> This change is very reasonable.
> 
> Do you mind checking that the ~20 other instances of hasChildNodes() do not have the same problem?

The remaining users look good.

[WebKit Review Bot]

Comment on attachment 191766 [details]
Patch

Clearing flags on attachment: 191766

Committed r144948: <http://trac.webkit.org/changeset/144948>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.