Bug 111581 - Web Inspector: fix closure compiler warnings in the profiler code
Summary: Web Inspector: fix closure compiler warnings in the profiler code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 07:50 PST by Yury Semikhatsky
Modified: 2013-03-06 08:30 PST (History)
9 users (show)

See Also:

Attachments
Patch (4.50 KB, patch)
2013-03-06 07:52 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-03-06 07:50:33 PST 
./Source/WebCore/inspector/compile-front-end.py 
Source/WebCore/inspector/front-end/FlameChart.js:202: WARNING - Type annotations are not allowed here. Are you missing parentheses?
        var levelOffsets = /** @type {Array.<!number>} */ [0];
^

Source/WebCore/inspector/front-end/ProfileLauncherView.js:200: WARNING - Property liveNativeMemoryChart never defined on WebInspector.experimentsSettings
    if (WebInspector.experimentsSettings.liveNativeMemoryChart.isEnabled()) {
        ^

Source/WebCore/inspector/front-end/ProfileLauncherView.js:203: WARNING - Property NativeMemoryBarChart never defined on WebInspector
        this._nativeMemoryLiveChart = new WebInspector.NativeMemoryBarChart();
                                          ^

0 error(s), 3 warning(s), 81.0% typed
Compiling InjectedScriptSource.js...
Source/WebCore/inspector/InjectedScriptSourceTmp.js:226: WARNING - Property objectId never defined on InjectedScriptHost
        var id = InjectedScriptHost.objectId(object);
                 ^

Source/WebCore/inspector/InjectedScriptSourceTmp.js:376: WARNING - Property releaseObjectId never defined on InjectedScriptHost
            InjectedScriptHost.releaseObjectId(object);
            ^

0 error(s), 2 warning(s), 90.3% typed
Compiling InjectedScriptCanvasModuleSource.js...
0 error(s), 0 warning(s), 92.4% typed
Comment 1 Yury Semikhatsky 2013-03-06 07:52:17 PST 
Created attachment 191750 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-06 08:30:20 PST 
Comment on attachment 191750 [details]
Patch

Clearing flags on attachment: 191750

Committed r144932: <http://trac.webkit.org/changeset/144932>
Comment 3 WebKit Review Bot 2013-03-06 08:30:23 PST 
All reviewed patches have been landed.  Closing bug.