Bug 111573 - Web Inspector: [ACE] add experimental breakpoint support
Summary: Web Inspector: [ACE] add experimental breakpoint support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 06:25 PST by Andrey Lushnikov
Modified: 2013-03-07 02:43 PST (History)
9 users (show)

See Also:

Attachments
Patch (7.05 KB, patch)
2013-03-06 06:32 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (7.16 KB, patch)
2013-03-06 07:40 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
breakpoints in ace (68.92 KB, image/png)
2013-03-06 07:40 PST, Andrey Lushnikov 		no flags Details
Patch (7.26 KB, patch)
2013-03-07 02:14 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-03-06 06:25:48 PST 
Add experimental breakpoint support.
Comment 1 Andrey Lushnikov 2013-03-06 06:32:09 PST 
Created attachment 191742 [details]
Patch
Comment 2 Pavel Feldman 2013-03-06 07:11:47 PST 
Comment on attachment 191742 [details]
Patch

Screenshots should go with UI changes
Comment 3 Andrey Lushnikov 2013-03-06 07:40:09 PST 
Created attachment 191748 [details]
Patch
Comment 4 Andrey Lushnikov 2013-03-06 07:40:33 PST 
Created attachment 191749 [details]
breakpoints in ace
Comment 5 WebKit Review Bot 2013-03-06 08:55:00 PST 
Comment on attachment 191748 [details]
Patch

Rejecting attachment 191748 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 191748, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13779 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
54>At revision 13779.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://webkit-commit-queue.appspot.com/results/17072097
Comment 6 Andrey Lushnikov 2013-03-07 02:14:36 PST 
Created attachment 191954 [details]
Patch
Comment 7 WebKit Review Bot 2013-03-07 02:43:29 PST 
Comment on attachment 191954 [details]
Patch

Clearing flags on attachment: 191954

Committed r145058: <http://trac.webkit.org/changeset/145058>
Comment 8 WebKit Review Bot 2013-03-07 02:43:33 PST 
All reviewed patches have been landed.  Closing bug.