Bug 111565 - [V8] REGRESSION(r144617): Wrong usage of overwritten variable in toDOMWindow (V8Binding.cpp)
Summary: [V8] REGRESSION(r144617): Wrong usage of overwritten variable in toDOMWindow ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marja Hölttä
URL:
Keywords:
Depends on:
Blocks: 110875
  Show dependency tree / graph
 
Reported: 2013-03-06 05:27 PST by Marja Hölttä
Modified: 2013-03-06 06:32 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2013-03-06 05:28 PST, Marja Hölttä 		no flags Details | Formatted Diff | Diff
Patch (2.17 KB, patch)
2013-03-06 05:46 PST, Marja Hölttä 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marja Hölttä 2013-03-06 05:27:31 PST 
The patch in bug 110875 wasn't quite right. This should fix it.
Comment 1 Marja Hölttä 2013-03-06 05:28:21 PST 
Created attachment 191726 [details]
Patch
Comment 2 Kentaro Hara 2013-03-06 05:30:52 PST 
Comment on attachment 191726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191726&action=review

The change looks reasonable.

> Source/WebCore/ChangeLog:3
> +        Follow up-fixes to bug 110875

It's good to mention that this is a follow-up fix for the bug, but please add a more descriptive title. Some people in WebKit are scanning all titles.

> Source/WebCore/ChangeLog:7
> +

Ditto. Please explain the rationale for the change.
Comment 3 jochen 2013-03-06 05:35:39 PST 
Comment on attachment 191726 [details]
Patch

ok.

please modify the changelog as kentaro requested
Comment 4 Marja Hölttä 2013-03-06 05:46:55 PST 
Created attachment 191734 [details]
Patch
Comment 5 Kentaro Hara 2013-03-06 05:47:32 PST 
Comment on attachment 191734 [details]
Patch

Thanks!
Comment 6 WebKit Review Bot 2013-03-06 06:32:46 PST 
Comment on attachment 191734 [details]
Patch

Clearing flags on attachment: 191734

Committed r144919: <http://trac.webkit.org/changeset/144919>
Comment 7 WebKit Review Bot 2013-03-06 06:32:49 PST 
All reviewed patches have been landed.  Closing bug.