WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111548
Web Inspector: test that "importScript" is used only in module heads.
https://bugs.webkit.org/show_bug.cgi?id=111548
Summary
Web Inspector: test that "importScript" is used only in module heads.
Andrey Lushnikov
Reported
2013-03-06 02:16:56 PST
Test that "importScript" function is called only in module heads to avoid bugs like
https://bugs.webkit.org/show_bug.cgi?id=111535
Attachments
Patch
(1.54 KB, patch)
2013-03-06 03:08 PST
,
Andrey Lushnikov
no flags
Details
Formatted Diff
Diff
Patch
(1.59 KB, patch)
2013-03-06 03:39 PST
,
Andrey Lushnikov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1
2013-03-06 03:08:37 PST
Created
attachment 191701
[details]
Patch
Pavel Feldman
Comment 2
2013-03-06 03:10:40 PST
Comment on
attachment 191701
[details]
Patch You want to raise exception here, not exit.
Andrey Lushnikov
Comment 3
2013-03-06 03:24:13 PST
This will exit with exitcode = 1 and error message. In the nutshell it raises SystemExit exception - so what's the difference?
Andrey Lushnikov
Comment 4
2013-03-06 03:39:32 PST
Created
attachment 191706
[details]
Patch
WebKit Review Bot
Comment 5
2013-03-06 07:23:06 PST
Comment on
attachment 191706
[details]
Patch Clearing flags on attachment: 191706 Committed
r144926
: <
http://trac.webkit.org/changeset/144926
>
WebKit Review Bot
Comment 6
2013-03-06 07:23:10 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug