Bug 111534 - [EFL] Improve warning messages when input value is out of range
Summary: [EFL] Improve warning messages when input value is out of range
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 111026
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-06 00:16 PST by Gyuyoung Kim
Modified: 2013-03-06 19:34 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.09 KB, patch)
2013-03-06 00:19 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Screenshot (91.47 KB, image/png)
2013-03-06 00:21 PST, Gyuyoung Kim
no flags Details
Patch (1.85 KB, patch)
2013-03-06 01:26 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (1.84 KB, patch)
2013-03-06 01:38 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (1.84 KB, patch)
2013-03-06 01:41 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-03-06 00:16:35 PST
It would be good if we show input value range when user inputs greater or less value.
Comment 1 Gyuyoung Kim 2013-03-06 00:19:07 PST
Created attachment 191668 [details]
Patch
Comment 2 Gyuyoung Kim 2013-03-06 00:21:19 PST
Created attachment 191669 [details]
Screenshot
Comment 3 Chris Dumez 2013-03-06 00:25:08 PST
Comment on attachment 191668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191668&action=review

I seem to remember Benjamin advising to use operator+ for such cases.

> Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:461
> +    builder.append(maximum.utf8().data());

Also using ".utf8().data()" seems odd here.
Comment 4 EFL EWS Bot 2013-03-06 01:18:24 PST
Comment on attachment 191668 [details]
Patch

Attachment 191668 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17051283
Comment 5 Gyuyoung Kim 2013-03-06 01:26:11 PST
Created attachment 191683 [details]
Patch
Comment 6 Gyuyoung Kim 2013-03-06 01:27:42 PST
(In reply to comment #3)
> (From update of attachment 191668 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191668&action=review
> 
> I seem to remember Benjamin advising to use operator+ for such cases.
> 
> > Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:461
> > +    builder.append(maximum.utf8().data());
> 
> Also using ".utf8().data()" seems odd here.

Ok, I modify this patch to be simplified.
Comment 7 Gyuyoung Kim 2013-03-06 01:38:13 PST
Created attachment 191688 [details]
Patch
Comment 8 Gyuyoung Kim 2013-03-06 01:41:16 PST
Created attachment 191689 [details]
Patch
Comment 9 Chris Dumez 2013-03-06 01:42:17 PST
Comment on attachment 191689 [details]
Patch

LGTM.
Comment 10 Laszlo Gombos 2013-03-06 18:50:13 PST
Comment on attachment 191689 [details]
Patch

r=me.
Comment 11 WebKit Review Bot 2013-03-06 19:34:21 PST
Comment on attachment 191689 [details]
Patch

Clearing flags on attachment: 191689

Committed r145025: <http://trac.webkit.org/changeset/145025>
Comment 12 WebKit Review Bot 2013-03-06 19:34:25 PST
All reviewed patches have been landed.  Closing bug.