RESOLVED FIXED 111534
[EFL] Improve warning messages when input value is out of range 
https://bugs.webkit.org/show_bug.cgi?id=111534
Summary [EFL] Improve warning messages when input value is out of range
Gyuyoung Kim
Reported 2013-03-06 00:16:35 PST
It would be good if we show input value range when user inputs greater or less value.
Attachments
Patch (2.09 KB, patch)
2013-03-06 00:19 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Screenshot (91.47 KB, image/png)
2013-03-06 00:21 PST, Gyuyoung Kim 		no flags
Details
Patch (1.85 KB, patch)
2013-03-06 01:26 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.84 KB, patch)
2013-03-06 01:38 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.84 KB, patch)
2013-03-06 01:41 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-03-06 00:19:07 PST
Created attachment 191668 [details] Patch
Gyuyoung Kim
Comment 2 2013-03-06 00:21:19 PST
Created attachment 191669 [details] Screenshot
Chris Dumez
Comment 3 2013-03-06 00:25:08 PST
Comment on attachment 191668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191668&action=review I seem to remember Benjamin advising to use operator+ for such cases. > Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:461 > + builder.append(maximum.utf8().data()); Also using ".utf8().data()" seems odd here.
EFL EWS Bot
Comment 4 2013-03-06 01:18:24 PST
Comment on attachment 191668 [details] Patch Attachment 191668 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17051283
Gyuyoung Kim
Comment 5 2013-03-06 01:26:11 PST
Created attachment 191683 [details] Patch
Gyuyoung Kim
Comment 6 2013-03-06 01:27:42 PST
(In reply to comment #3) > (From update of attachment 191668 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191668&action=review > > I seem to remember Benjamin advising to use operator+ for such cases. > > > Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:461 > > + builder.append(maximum.utf8().data()); > > Also using ".utf8().data()" seems odd here. Ok, I modify this patch to be simplified.
Gyuyoung Kim
Comment 7 2013-03-06 01:38:13 PST
Created attachment 191688 [details] Patch
Gyuyoung Kim
Comment 8 2013-03-06 01:41:16 PST
Created attachment 191689 [details] Patch
Chris Dumez
Comment 9 2013-03-06 01:42:17 PST
Comment on attachment 191689 [details] Patch LGTM.
Laszlo Gombos
Comment 10 2013-03-06 18:50:13 PST
Comment on attachment 191689 [details] Patch r=me.
WebKit Review Bot
Comment 11 2013-03-06 19:34:21 PST
Comment on attachment 191689 [details] Patch Clearing flags on attachment: 191689 Committed r145025: <http://trac.webkit.org/changeset/145025>
WebKit Review Bot
Comment 12 2013-03-06 19:34:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.