Bug 111519 – REGRESSION(r144859): Introduced a test that calls non-exist function on non-Chromium ports and crash on Chromium (Requested by rniwa on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/144859 broke the build:
Introduced a test that calls non-exist function on non-Chromium ports and crash on Chromium (Requested by rniwa on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 191647 [details]
ROLLOUT of r144859

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Eric Seidel (no email)]

OK.

[Ryosuke Niwa]

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=http%2Ftests%2Fmisc%2Fdelete-frame-during-readystatechange-with-gc-after-video-removal.html

The patch added a test that doens’t do anything useful on non-Chromium ports due to window.gc missing: e.g.
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r144864%20(7585)/http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal-pretty-diff.html

And it’s crashing on Chromium:
http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r144863%20(45638)/http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal-crash-log.txt

[Ryosuke Niwa]

Unfortunately, I don’t have the full context at my disposal since I don’t have access to the bug.

However, given that the only test added by this patch doesn’t function anywhere but Chromium and crahses on Chromium, it appears to me that this patch doesn’t seem to fix the bug it claims to fix.

[Hayato Ito]

As we chatted in #webkit, I am going to cq+ soon.

[WebKit Review Bot]

Comment on attachment 191647 [details]
ROLLOUT of r144859

Clearing flags on attachment: 191647

Committed r144896: <http://trac.webkit.org/changeset/144896>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.