Bug 111508 - [chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp
Summary: [chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on: 111504 111509
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-05 18:49 PST by James Robinson
Modified: 2013-03-06 13:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2013-03-05 18:55 PST, James Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-03-05 18:49:42 PST 
[chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp
Comment 1 James Robinson 2013-03-05 18:55:06 PST 
Created attachment 191635 [details]
Patch
Comment 2 James Robinson 2013-03-05 19:02:25 PST 
Comment on attachment 191635 [details]
Patch

cq- for now, looks like the patch this depends on (to create DumpRenderTree_resources) is having some trouble with the xcode generator.
Comment 3 Dirk Pranke 2013-03-05 19:15:46 PST 
(In reply to comment #2)
> (From update of attachment 191635 [details])
> cq- for now, looks like the patch this depends on (to create DumpRenderTree_resources) is having some trouble with the xcode generator.

Yeah, it looks like putting the resources in a separate target may or may not work correctly w/ xcode. Let's wait and see what nico says about this.
Comment 4 Dirk Pranke 2013-03-06 12:55:35 PST 
Comment on attachment 191635 [details]
Patch

I think this should be fine w/ Tony's approach in bug 11509.
Comment 5 WebKit Review Bot 2013-03-06 13:14:08 PST 
Comment on attachment 191635 [details]
Patch

Clearing flags on attachment: 191635

Committed r144970: <http://trac.webkit.org/changeset/144970>
Comment 6 WebKit Review Bot 2013-03-06 13:14:11 PST 
All reviewed patches have been landed.  Closing bug.