Bug 111491 - editing/pasteboard/paste-table-cells.html should be a dump-as-markup test
Summary: editing/pasteboard/paste-table-cells.html should be a dump-as-markup test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 111360
  Show dependency treegraph
 
Reported: 2013-03-05 15:55 PST by Ryosuke Niwa
Modified: 2013-03-06 11:36 PST (History)
8 users (show)

See Also:


Attachments
Converts the test (21.99 KB, patch)
2013-03-05 15:59 PST, Ryosuke Niwa
leviw: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-03-05 15:55:56 PST
editing/pasteboard/paste-table-cells.html is much better served as a dump-as-markup test.
Comment 1 Ryosuke Niwa 2013-03-05 15:59:03 PST
Created attachment 191591 [details]
Converts the test
Comment 2 Build Bot 2013-03-05 17:49:04 PST
Comment on attachment 191591 [details]
Converts the test

Attachment 191591 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17044075

New failing tests:
editing/pasteboard/paste-table-cells.html
Comment 3 WebKit Review Bot 2013-03-05 23:11:24 PST
Comment on attachment 191591 [details]
Converts the test

Attachment 191591 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17018054

New failing tests:
editing/pasteboard/paste-table-cells.html
Comment 4 Ryosuke Niwa 2013-03-06 09:06:24 PST
(In reply to comment #2)
> (From update of attachment 191591 [details])
> Attachment 191591 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-commit-queue.appspot.com/results/17044075
> 
> New failing tests:
> editing/pasteboard/paste-table-cells.html

I don't understand all these failures. I saw the same thing on https://bugs.webkit.org/show_bug.cgi?id=111400. It's as if the bot is not applying the patch correctly :/
Comment 5 Build Bot 2013-03-06 09:37:10 PST
Comment on attachment 191591 [details]
Converts the test

Attachment 191591 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17008106

New failing tests:
editing/pasteboard/paste-table-cells.html
Comment 6 Ryosuke Niwa 2013-03-06 10:58:20 PST
Apparently webkit-patch apply-attachemnt didn't delete the following files:
D         LayoutTests/platform/chromium-mac-lion/editing/pasteboard/paste-table-cells-expected.png
D         LayoutTests/platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png
D         LayoutTests/platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.png
D         LayoutTests/platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png
D         LayoutTests/platform/chromium-win/editing/pasteboard/paste-table-cells-expected.txt
D         LayoutTests/platform/gtk/editing/pasteboard/paste-table-cells-expected.txt
D         LayoutTests/platform/mac/editing/pasteboard/paste-table-cells-expected.txt
D         LayoutTests/platform/qt/editing/pasteboard/paste-table-cells-expected.txt
Comment 7 Levi Weintraub 2013-03-06 11:03:02 PST
Comment on attachment 191591 [details]
Converts the test

Awesome!
Comment 8 Ryosuke Niwa 2013-03-06 11:05:36 PST
Filed https://bugs.webkit.org/show_bug.cgi?id=111601 to track the apply-attachment issue.
Comment 9 Ryosuke Niwa 2013-03-06 11:36:26 PST
Committed r144956: <http://trac.webkit.org/changeset/144956>