Bug 111485 – Dashboard cleanup: move string utilities into their own namespace.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Julie Parent]

Dashboard cleanup: move string utilities into their own namespace.

[Julie Parent]

Created attachment 191572 [details]
Patch

[Ojan Vafai]

Comment on attachment 191572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191572&action=review

> Tools/TestResultServer/static-dashboards/string.js:30
> +var stringUtil = stringUtil || {};

How about s/stringUtil/string?

[Julie Parent]

Comment on attachment 191572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191572&action=review

>> Tools/TestResultServer/static-dashboards/string.js:30
>> +var stringUtil = stringUtil || {};
> 
> How about s/stringUtil/string?

I originally used string, but I thought that was confusing because there is the built-in String.

[Ojan Vafai]

Util is a useless word. I don't think there's much threat of people confusing string.contains with String.contains. 

I'd rather have something like base.string than stringUtil. My preference is still for just plain string though.

[Julie Parent]

Created attachment 191584 [details]
Patch

[Julie Parent]

(In reply to comment #4)
> Util is a useless word. I don't think there's much threat of people confusing string.contains with String.contains. 
> 
> I'd rather have something like base.string than stringUtil. My preference is still for just plain string though.

Changed to string.

[WebKit Review Bot]

Comment on attachment 191584 [details]
Patch

Clearing flags on attachment: 191584

Committed r144845: <http://trac.webkit.org/changeset/144845>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.