Bug 111467 - Each web process truncates the disk cache to zero on launch
Summary: Each web process truncates the disk cache to zero on launch
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
Depends on:
Reported: 2013-03-05 12:40 PST by Geoffrey Garen
Modified: 2013-03-06 11:50 PST (History)
1 user (show)

See Also:

Patch (2.71 KB, patch)
2013-03-05 12:42 PST, Geoffrey Garen
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2013-03-05 12:40:45 PST
Each web process truncates the disk cache to zero on launch
Comment 1 Geoffrey Garen 2013-03-05 12:42:57 PST
Created attachment 191537 [details]
Comment 2 Darin Adler 2013-03-05 14:04:19 PST
Comment on attachment 191537 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=191537&action=review

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:165
> +            NSUInteger cacheMemoryCapacity = parameters.nsURLCacheMemoryCapacity;
> +            NSUInteger cacheDiskCapacity = parameters.nsURLCacheDiskCapacity;

Strange to put two arguments into local variables here, but not the third. All three or none?

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:168
> +                RetainPtr<NSURLCache> parentProcessURLCache(AdoptNS, [[NSURLCache alloc] initWithMemoryCapacity:cacheMemoryCapacity diskCapacity:cacheDiskCapacity diskPath:parameters.diskCacheDirectory]);
> +                [NSURLCache setSharedURLCache:parentProcessURLCache.get()];

Wrong indentation here.
Comment 3 Geoffrey Garen 2013-03-05 18:15:35 PST
Committed r144860: <http://trac.webkit.org/changeset/144860>
Comment 4 Darin Adler 2013-03-06 11:23:14 PST
More style comments for Geoff:

1) The adoptNS function is so much better than RetainPtr<xxx> yyy(AdoptNS, zzz).

2) No local variable needed.

So next time I have a chance Iā€™d just change this to:

    [NSURLCache setSharedURLCache:adoptNS([[NSURLCache alloc]

Just wanted to get you into the adoptNS/adoptCF/adoptRef club!
Comment 5 Geoffrey Garen 2013-03-06 11:50:26 PST
Committed r144958: <http://trac.webkit.org/changeset/144958>