Implement WebInspector::localizedStringsURL() method, so that it will prevent printing warnings about "Localized string not found" in the console when the Web Inspector opened.
Created attachment 191729 [details] Patch
I wonder if this should be included in the GResources bundle. What do you think Carlos?
We don't have GResource bundle yet, no? my plan was to include all the inspector resources as a GResource in the library itself, to avoid the problems of resources not found when not installed and to avoid a lot of disk io.
(In reply to comment #3) > We don't have GResource bundle yet, no? my plan was to include all the inspector resources as a GResource in the library itself, to avoid the problems of resources not found when not installed and to avoid a lot of disk io. Sorry. I thought inspector resources were already stored as GResource data in the library itself. If not, this patch seems fine to me.
(In reply to comment #4) > (In reply to comment #3) > > We don't have GResource bundle yet, no? my plan was to include all the inspector resources as a GResource in the library itself, to avoid the problems of resources not found when not installed and to avoid a lot of disk io. > > Sorry. I thought inspector resources were already stored as GResource data in the library itself. If not, this patch seems fine to me. For now it's only a plan, the main problem is that we would need to bump glib (and probably libsoup) requirements, or do both, install the resources and compile them as a gresource, falling back to the installed files if the resources are not present in the library.
Maybe a WebKit2 owner could put the final stamp on this one?
Comment on attachment 191729 [details] Patch Thanks for reviewing.
Comment on attachment 191729 [details] Patch Clearing flags on attachment: 191729 Committed r144982: <http://trac.webkit.org/changeset/144982>
All reviewed patches have been landed. Closing bug.