WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111442
Web Inspector: Flame Chart. Provide node context info in a popover when mouse hovers over a flame chart item
https://bugs.webkit.org/show_bug.cgi?id=111442
Summary
Web Inspector: Flame Chart. Provide node context info in a popover when mouse...
Ilya Tikhonovsky
Reported
2013-03-05 08:04:22 PST
EOM
Attachments
Patch
(5.38 KB, patch)
2013-03-05 08:07 PST
,
Ilya Tikhonovsky
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2013-03-05 08:07:03 PST
Created
attachment 191499
[details]
Patch
Yury Semikhatsky
Comment 2
2013-03-05 08:24:32 PST
Comment on
attachment 191499
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=191499&action=review
Please attach a screenshot.
> Source/WebCore/ChangeLog:8 > + FlameChart creates a fake anchor element and moves it to the right position.
Can you rephrase this or add more context?
> Source/WebCore/inspector/front-end/FlameChart.js:93 > + if (typeof node === 'undefined' && !this._highlightedNode)
Please use " instead of '
> Source/WebCore/inspector/front-end/FlameChart.js:120 > + style.height = this._yScaleFactor + "px";
Consider renaming _yScaleFactor to _barHeight
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug