WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
UNCONFIRMED
11144
Double Click Never invokes handleMousePressEvent() a second time with clickCount = 2
https://bugs.webkit.org/show_bug.cgi?id=11144
Summary
Double Click Never invokes handleMousePressEvent() a second time with clickCo...
Hunter L. Williams
Reported
2006-10-03 17:52:42 PDT
On Windows, if you double click, you generate this sequence of events (per Don Gibson): *BUTTONDOWN *BUTTONUP *BUTTONDBLCLK *BUTTONUP The DBLCLK comes in place of the second BUTTONDOWN, however it ends up calling handleMouseReleaseEvent on FrameView. This means that functionality in Frame, like selecting words by double clicking, doesn't work, since their implementation is in handleMousePressEvent (inspecting the clickCount for == 2). I'm not sure what the exact fix is, I'm going to experiment by having WebView::mouseDoubleClick call the FrameView's handleMousePressEvent function instead of Release.
Attachments
Add attachment
proposed patch, testcase, etc.
Don Gibson
Comment 1
2006-10-03 18:39:59 PDT
One reason that I believe the current code calls the Release function on a double click is because this to some degree fakes up how Windows deals with double clicks. Generally in Windows, single click actions are taken on buttonup, but double click actions are taken on buttondown, with the subsequent buttonup basically being ignored. For example, try double-clicking a desktop shortcut and holding the second click. Inside WebKit, at a cursory glance, it looks like actions generally happen on releases, so I suspect the "release" function is getting called so that something will happen immediately on the second button press in the double click case. I'm not sure this is correct. It's worth investigating what events pages expect to receive in these sorts of cases. It might be that the second click should call the "press" function just like a single click does; or perhaps it should call first "press" and then "release"; or perhaps it should call both, and the subsequent buttonup should be silently eaten. I'm inclined to believe that the low-level event handling shouldn't lie about presses versus releases, and if frames, anchors, or various other objects want to handle clicks differently, they should do it at that level. But perhaps this conflicts with the Mac platform.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug