Bug 111431 - Web Inspector: move PopoverContentHelper from TimelinePresentationModel.js to Popover.js
Summary: Web Inspector: move PopoverContentHelper from TimelinePresentationModel.js to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-05 06:18 PST by Ilya Tikhonovsky
Modified: 2013-03-05 07:31 PST (History)
8 users (show)

See Also:

Attachments
Patch (26.72 KB, patch)
2013-03-05 06:31 PST, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-03-05 06:18:59 PST 
I'd like to reuse PopoverContentHelper in FlameChart.
Comment 1 Ilya Tikhonovsky 2013-03-05 06:31:33 PST 
Created attachment 191483 [details]
Patch
Comment 2 Andrey Kosyakov 2013-03-05 06:32:51 PST 
Comment on attachment 191483 [details]
Patch

LGTM
Comment 3 Yury Semikhatsky 2013-03-05 06:43:31 PST 
Comment on attachment 191483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191483&action=review

> Source/WebCore/inspector/front-end/Popover.js:374
> +WebInspector.PopupContentHelper = function(title)

Consider renaming to PopoverTableHelper ?

> Source/WebCore/inspector/front-end/Popover.js:430
> +    appendStackTrace: function(title, stackTrace, callFrameLinkifier)

Now Popover.js depends on the stack trace, can we avoid this?
Comment 4 Ilya Tikhonovsky 2013-03-05 07:31:25 PST 
Committed r144759: <http://trac.webkit.org/changeset/144759>