Bug 111423 – CompactHTMLToken does not need an XSSInfo pointer

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

CompactHTMLToken does not need an XSSInfo pointer

It appears the XSSInfo objects have nothing to do with the token?  They could be held on the ParsedChunk in a side-vector and take up much less space.  We could even associated them to a TokenIndex if that's important, but it doesn't seem to be from my reading of the code?

[Adam Barth]

Yeah, they can probably move to the ParsedChunk.

[Tony Gentilcore]

Good catch. I can take care of this.

[Tony Gentilcore]

Created attachment 191528 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 191528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191528&action=review

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:400
> +            break;

This will end up producing a slightly different tree than before.  I'm not sure if that matters.

[Tony Gentilcore]

(In reply to comment #4)
> (From update of attachment 191528 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191528&action=review
> 
> > Source/WebCore/html/parser/HTMLDocumentParser.cpp:400
> > +            break;
> 
> This will end up producing a slightly different tree than before.  I'm not sure if that matters.

Yes it will. Only in the case the entire page is blocked. And I don't think it matters in that case.

[WebKit Review Bot]

Comment on attachment 191528 [details]
Patch

Clearing flags on attachment: 191528

Committed r144801: <http://trac.webkit.org/changeset/144801>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.