Bug 111423 - CompactHTMLToken does not need an XSSInfo pointer
Summary: CompactHTMLToken does not need an XSSInfo pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-03-05 04:49 PST by Eric Seidel (no email)
Modified: 2013-03-05 12:46 PST (History)
6 users (show)

See Also:


Attachments
Patch (11.18 KB, patch)
2013-03-05 11:51 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-03-05 04:49:33 PST
CompactHTMLToken does not need an XSSInfo pointer

It appears the XSSInfo objects have nothing to do with the token?  They could be held on the ParsedChunk in a side-vector and take up much less space.  We could even associated them to a TokenIndex if that's important, but it doesn't seem to be from my reading of the code?
Comment 1 Adam Barth 2013-03-05 09:37:27 PST
Yeah, they can probably move to the ParsedChunk.
Comment 2 Tony Gentilcore 2013-03-05 09:55:31 PST
Good catch. I can take care of this.
Comment 3 Tony Gentilcore 2013-03-05 11:51:33 PST
Created attachment 191528 [details]
Patch
Comment 4 Eric Seidel (no email) 2013-03-05 12:04:06 PST
Comment on attachment 191528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191528&action=review

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:400
> +            break;

This will end up producing a slightly different tree than before.  I'm not sure if that matters.
Comment 5 Tony Gentilcore 2013-03-05 12:07:58 PST
(In reply to comment #4)
> (From update of attachment 191528 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191528&action=review
> 
> > Source/WebCore/html/parser/HTMLDocumentParser.cpp:400
> > +            break;
> 
> This will end up producing a slightly different tree than before.  I'm not sure if that matters.

Yes it will. Only in the case the entire page is blocked. And I don't think it matters in that case.
Comment 6 WebKit Review Bot 2013-03-05 12:46:39 PST
Comment on attachment 191528 [details]
Patch

Clearing flags on attachment: 191528

Committed r144801: <http://trac.webkit.org/changeset/144801>
Comment 7 WebKit Review Bot 2013-03-05 12:46:43 PST
All reviewed patches have been landed.  Closing bug.