Bug 111419 - Web Inspector: identify reflection layers in LayerTreeAgent
Summary: Web Inspector: identify reflection layers in LayerTreeAgent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-05 03:56 PST by Antoine Quint
Modified: 2013-03-05 14:51 PST (History)
12 users (show)

See Also:


Attachments
Patch (13.52 KB, patch)
2013-03-05 06:01 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (13.52 KB, patch)
2013-03-05 14:09 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2013-03-05 03:56:20 PST
Some layers are created to provide the reflection of an element, as provided by the CSS property -webkit-box-reflect. Since these layers' renderer is not directly associated to a Node and we'll probably want to identify as such in the UI, we should clearly identify such layers as reflection layers.
Comment 1 Radar WebKit Bug Importer 2013-03-05 03:56:45 PST
<rdar://problem/13346525>
Comment 2 Antoine Quint 2013-03-05 06:01:26 PST
Created attachment 191480 [details]
Patch
Comment 3 Dean Jackson 2013-03-05 12:27:09 PST
Comment on attachment 191480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191480&action=review

> Source/WebCore/ChangeLog:10
> +        id, since there is no node per-se directly associated to this layer.

s/to/with
Comment 4 Antoine Quint 2013-03-05 14:09:07 PST
Created attachment 191559 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-03-05 14:50:58 PST
Comment on attachment 191559 [details]
Patch for landing

Clearing flags on attachment: 191559

Committed r144824: <http://trac.webkit.org/changeset/144824>
Comment 6 WebKit Review Bot 2013-03-05 14:51:02 PST
All reviewed patches have been landed.  Closing bug.