WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111415
PDFPlugin: Make scrolling between pages in non-continuous modes work
https://bugs.webkit.org/show_bug.cgi?id=111415
Summary
PDFPlugin: Make scrolling between pages in non-continuous modes work
Tim Horton
Reported
2013-03-05 01:38:06 PST
<
rdar://problem/12555320
>
Attachments
patch that needs some love
(4.62 KB, patch)
2013-03-05 02:18 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
patch
(7.01 KB, patch)
2013-03-11 00:10 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
stylebot
(7.00 KB, patch)
2013-03-11 07:23 PDT
,
Tim Horton
ap
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2013-03-05 02:18:09 PST
Created
attachment 191441
[details]
patch that needs some love
Tim Horton
Comment 2
2013-03-11 00:10:03 PDT
Created
attachment 192410
[details]
patch
WebKit Review Bot
Comment 3
2013-03-11 00:50:33 PDT
Attachment 192410
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFLayerControllerDetails.h', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm']" exit_code: 1 Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:116: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4
2013-03-11 07:23:48 PDT
Created
attachment 192465
[details]
stylebot
Alexey Proskuryakov
Comment 5
2013-03-11 16:44:39 PDT
Comment on
attachment 192465
[details]
stylebot View in context:
https://bugs.webkit.org/attachment.cgi?id=192465&action=review
> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:90 > +static int defaultScrollMagnitudeThresholdForPageFlip = 20;
s/static/const/?
> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:1010 > + [CATransaction begin];
I don't know why this is needed, taking on trust.
Tim Horton
Comment 6
2013-03-11 16:49:37 PDT
http://trac.webkit.org/changeset/145432
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug