Bug 111414 – [GTK] Expose "ShouldRespectImageOrientation" setting into WebKitWebSettings

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Tomas Popela]

We should expose ShouldRespectImageOrientation into WebKitWebSettings as discussed here: https://lists.webkit.org/pipermail/webkit-gtk/2013-March/001372.html .

[Tomas Popela]

Created attachment 191422 [details]
Proposed patch

[WebKit Review Bot]

Attachment 191422 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebsettings.cpp', u'Source/WebKit/gtk/webkit/webkitwebsettingsprivate.h', u'Source/WebKit/gtk/webkit/webkitwebview.cpp']" exit_code: 1
Source/WebKit/gtk/webkit/webkitwebsettings.cpp:284:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 191422 [details]
Proposed patch

Looks good to me. Just need another review from a GTK+ port maintainer to land this one.

[Tomas Popela]

Ok.. And can we also include it in webkitgtk2.0 release?

[Martin Robinson]

We don't like to add API late in the cycle, but this seems pretty low risk. Can you add this bug to: http://trac.webkit.org/wiki/WebKitGTK/2.0.x

[Martin Robinson]

Adding a couple more port maintainers who could flip the flag here.

[Carlos Garcia Campos]

Comment on attachment 191422 [details]
Proposed patch

This looks good to me, you need approval from another reviewer since this is new API.

[Carlos Garcia Campos]

Comment on attachment 191422 [details]
Proposed patch

Martin already reviewed it, sorry.

[WebKit Review Bot]

Comment on attachment 191422 [details]
Proposed patch

Clearing flags on attachment: 191422

Committed r145070: <http://trac.webkit.org/changeset/145070>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.