Bug 111407 – Coordinated Graphics: Add contentsSizeDidChange() to increase readability.

• Status: NEW
• Component: Layout and Rendering

[Dongseong Hwang]

Add contentsSizeDidChange() to prevent from overusing sizeDidChange() callback
when contents size is changed.

[Dongseong Hwang]

Created attachment 191402 [details]
Patch

[Noam Rosenthal]

Comment on attachment 191402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191402&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:240
> +    if (!m_webPage->useFixedLayout())
> +        nonCompositedContentsSizeDidChange(newSize);
> +}
> +
> +void CoordinatedLayerTreeHost::contentsSizeDidChange(const IntSize& newSize)
> +{
> +    if (m_webPage->useFixedLayout())
> +        nonCompositedContentsSizeDidChange(newSize);

This looks funny... I don't understand how CLTHost deals with fixed layout vs. non-fixed layout.
Does any port even use CoordinatedGraphics without fixed layout? Is that tested anywhere?

[Dongseong Hwang]

(In reply to comment #2)
> (From update of attachment 191402 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191402&action=review
> This looks funny... I don't understand how CLTHost deals with fixed layout vs. non-fixed layout.
> Does any port even use CoordinatedGraphics without fixed layout? Is that tested anywhere?

I agree that it's funny. I hope Coordinated Graphics does not deal with non-fixed layout in the future.

I think WebKitTestRunner does not use fixedLayout in both EFL and Qt.

[Dongseong Hwang]

I filed this bug to prepare Bug 110066.

When turning off delegatesScrolling and fixedVisibleContentsRect, CoordinatedLayerTreeHost need to update visible contents rect when WebPage::m_viewSize is changed. However, currently CoordinatedLayerTreeHost   does not know when WebPage::m_viewSize is changed. So I filed this bug.

and, I think this patch increases readability a little bit.

[Dongseong Hwang]

The sub goal of this patch clarifies as follows:
o. if coordinated graphics uses fixed layout, the size of non composited contents is contents size.
o. if coordinated graphics does not use fixed layout, the size of non composited contents is view size.

WDYT?

[Noam Rosenthal]

Comment on attachment 191402 [details]
Patch

Clearing review flags for now.