Bug 111406 - Coordinated Graphics: Handle scrolling correctly.
Summary: Coordinated Graphics: Handle scrolling correctly.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on:
Blocks: 110066
  Show dependency treegraph
 
Reported: 2013-03-04 22:02 PST by Dongseong Hwang
Modified: 2013-03-08 08:35 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.04 KB, patch)
2013-03-04 22:04 PST, Dongseong Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2013-03-04 22:02:23 PST
Coordinated Graphics deals with fast scrolling and slow scrolling in the same
routine, so WebChromeClient::invalidateContentsForSlowScroll should call
DrawingArea:scroll().

When CoordinatedLayerTreeHost::scrollNonCompositedContents() is called, we
should call scheduleLayerFlush() to notify to UI Process. In addition, when we
don't use fixed layout, we should call setNonCompositedContentsNeedDisplay() to
update non composited contents.
Comment 1 Dongseong Hwang 2013-03-04 22:04:08 PST
Created attachment 191400 [details]
Patch
Comment 2 Noam Rosenthal 2013-03-08 02:33:53 PST
Comment on attachment 191400 [details]
Patch

This is fine with me; Please ask andersca or smfr for WK2 sign off.
Comment 3 Dongseong Hwang 2013-03-08 02:47:02 PST
(In reply to comment #2)
> (From update of attachment 191400 [details])
> This is fine with me; Please ask andersca or smfr for WK2 sign off.

yes, thank you for review :)
Comment 4 WebKit Review Bot 2013-03-08 08:35:49 PST
Comment on attachment 191400 [details]
Patch

Clearing flags on attachment: 191400

Committed r145230: <http://trac.webkit.org/changeset/145230>
Comment 5 WebKit Review Bot 2013-03-08 08:35:53 PST
All reviewed patches have been landed.  Closing bug.