Bug 111399 - Inline min/maxInstrinsicLogicalWidth functions
Summary: Inline min/maxInstrinsicLogicalWidth functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 20:02 PST by Ojan Vafai
Modified: 2013-03-05 14:06 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.22 KB, patch)
2013-03-05 12:03 PST, Ojan Vafai 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2013-03-04 20:02:30 PST 
Inline min/maxInstrinsicLogicalWidth functions
Comment 1 Ojan Vafai 2013-03-05 12:03:42 PST 
Created attachment 191530 [details]
Patch
Comment 2 Tony Chang 2013-03-05 12:44:06 PST 
Comment on attachment 191530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191530&action=review

> Source/WebCore/rendering/RenderBox.cpp:2116
> +        RenderView* renderView = view();
> +        LayoutUnit marginStart = minimumValueForLength(style()->marginStart(), availableLogicalWidth, renderView);
> +        LayoutUnit marginEnd = minimumValueForLength(style()->marginEnd(), availableLogicalWidth, renderView);

Maybe you should pass in 2 additional args to fillAvailableMeasure that will return marginStart and marginEnd by reference?  Maybe this should just be 2 separate methods.
Comment 3 Ojan Vafai 2013-03-05 14:06:55 PST 
Committed r144816: <http://trac.webkit.org/changeset/144816>